Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
keep the status error from envelope service #82543
this PR will propagate the status error from envelope provider to metrics so that can record the useful error code for better monitoring.
i would like to treat this as a bug, because it blinds us from differentiating errors we got from envelope provider. if envelope provider returns FailedPrecondition, right now will classify it as Unknown.
What type of PR is this?
Hi @shihan9. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
@shihan9: Cannot trigger testing until a trusted user reviews the PR and leaves an
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing