Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alpha message #82548

Merged
merged 2 commits into from Sep 12, 2019

Conversation

@apelisse
Copy link
Member

commented Sep 10, 2019

Update API documentation to remove alpha message about ManagedFields.

What type of PR is this?
/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


apelisse added 2 commits Sep 10, 2019
@liggitt

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

/unassign deads2k davidopp
/assign

API docs change that got missed when switching the gate to beta

/wg apply
/sig api-machinery

/priority critical-urgent
/milestone v1.16

@liggitt

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

cc @kubernetes/release-team for visibility

no risk (godoc-only change), and doesn't invalidate rc1 testing/feedback. including in the milestone to ensure 1.16 docs are accurate and avoid user confusion

@liggitt

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 10, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@apelisse

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

/retest

1 similar comment
@apelisse

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2019

/retest

@fejta-bot

This comment has been minimized.

Copy link

commented Sep 10, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@josiahbjorgaard

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

Bug Triage team on 1.16 release here. Since we have passed code freeze, PRs intended for 1.16 will need to go through approval to be cherry-picked. The deadline for cherry-picks is tomorrow EOD. Description of the approval process for cherry-picks is available here.

@k8s-ci-robot k8s-ci-robot merged commit 89cb15b into kubernetes:master Sep 12, 2019

25 checks passed

cla/linuxfoundation apelisse authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Skipped.
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.16, v1.17 Sep 12, 2019

k8s-ci-robot added a commit that referenced this pull request Sep 12, 2019
Merge pull request #82555 from apelisse/automated-cherry-pick-of-#825…
…48-kubernetes-release-1.16

Automated cherry pick of #82548: Remove alpha status from ManagedFields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.