Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the error return from AddPlugin #82552

Closed
wants to merge 1 commit into from

Conversation

@tedyu
Copy link
Contributor

commented Sep 10, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Currently the error return from actualStateOfWorldUpdater.AddPlugin is ignored.

This PR adds the check of the error return.

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tedyu
To complete the pull request process, please assign saad-ali
You can assign the PR to them by writing /assign @saad-ali in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tedyu

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

@dashpole
Can you review this ?

Thanks

@mattjmcnaughton
Copy link
Contributor

left a comment

Checking the return value of the actualStateOfWorldUpdater certainly seems more consistent with the behavior throughout the rest of the function. However, I'm wondering - do we know the reason that we were originally not checking the error? One slightly less drastic change here could be logging that the error occurred, instead of forcing the function to return?

@yutedz yutedz force-pushed the yutedz:op-gen-plugin-err branch from 294b383 to 1ba28a9 Sep 11, 2019

@tedyu

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

I have changed to logging the error return.

@dashpole
Please comment.

@yutedz yutedz force-pushed the yutedz:op-gen-plugin-err branch from 1ba28a9 to c1e782a Sep 11, 2019

@tedyu tedyu closed this Sep 11, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

@tedyu: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration c1e782a link /test pull-kubernetes-integration
pull-kubernetes-verify c1e782a link /test pull-kubernetes-verify
pull-kubernetes-bazel-test c1e782a link /test pull-kubernetes-bazel-test
pull-kubernetes-node-e2e c1e782a link /test pull-kubernetes-node-e2e
pull-kubernetes-typecheck c1e782a link /test pull-kubernetes-typecheck
pull-kubernetes-e2e-gce c1e782a link /test pull-kubernetes-e2e-gce
pull-kubernetes-kubemark-e2e-gce-big c1e782a link /test pull-kubernetes-kubemark-e2e-gce-big
pull-kubernetes-node-e2e-containerd c1e782a link /test pull-kubernetes-node-e2e-containerd
pull-kubernetes-e2e-gce-device-plugin-gpu c1e782a link /test pull-kubernetes-e2e-gce-device-plugin-gpu
pull-kubernetes-dependencies c1e782a link /test pull-kubernetes-dependencies
pull-kubernetes-e2e-gce-100-performance c1e782a link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-bazel-build c1e782a link /test pull-kubernetes-bazel-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tedyu

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

in favor of #82594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.