Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FieldManager tests to make them simpler #82554

Merged

Conversation

@apelisse
Copy link
Member

commented Sep 10, 2019

This is the first step on this, but there are a few improvements that
I'd like to do here.

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

"apiVersion": "apps/v1",
"kind": "Pod",
"metadata": {
"name": "b",
"namespace": "b",
"namespace": "b"

This comment has been minimized.

Copy link
@jennybuckley

jennybuckley Sep 11, 2019

Contributor

Why did this change?

This comment has been minimized.

Copy link
@apelisse

apelisse Sep 11, 2019

Author Member

/shrug

No idea, reverting :-)

return err
}

func (f *TestFieldManager) CompareObject(obj runtime.Object) error {

This comment has been minimized.

Copy link
@jennybuckley

jennybuckley Sep 11, 2019

Contributor

Is this used?

This comment has been minimized.

Copy link
@apelisse

apelisse Sep 11, 2019

Author Member

Interesting to see that we're never checking that the object is what we would expect. I'll remove it for now, especially since I'm not exactly sure how to implement it yet anyway.

@apelisse apelisse force-pushed the apelisse:improve-testmanager-helpers branch from f2dcdc2 to c86ee8c Sep 11, 2019

@apelisse

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

Addressed comments, thanks!

Refactor FieldManager tests to make them simpler
This is the first step on this, but there are a few improvements that
I'd like to do here.

@apelisse apelisse force-pushed the apelisse:improve-testmanager-helpers branch from c86ee8c to b10ad55 Sep 11, 2019

@apelisse

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

OK Fixed the tests, it needed a rebase

@jennybuckley

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

/retest
/lgtm

@fejta-bot

This comment has been minimized.

Copy link

commented Sep 12, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 28462fc into kubernetes:master Sep 12, 2019

25 checks passed

cla/linuxfoundation apelisse authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Skipped.
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.