Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: relex namespace restrictions for critical pod - part1 #82558

Open
wants to merge 1 commit into
base: master
from

Conversation

@draveness
Copy link
Member

commented Sep 11, 2019

/kind feature
/priority important-soon

What this PR does / why we need it:

  • Remove limitation of critical pod creation in kube-system namespace in pod priority admission plugin

Which issue(s) this PR fixes:

ref: #82480

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-scheduling/20190409-resource-quota-ga.md
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: draveness
To complete the pull request process, please assign derekwaynecarr
You can assign the PR to them by writing /assign @derekwaynecarr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@draveness draveness force-pushed the draveness:feature/remove-critical-pod-limitation branch from eeaab1e to a1053a4 Sep 11, 2019

@k8s-ci-robot k8s-ci-robot added size/S and removed size/M labels Sep 11, 2019

@draveness draveness force-pushed the draveness:feature/remove-critical-pod-limitation branch from a1053a4 to 51f7c4a Sep 11, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

@draveness: The label(s) sig/apimachinery cannot be appled. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

In response to this:

/sig apimachinery
/sig scheduling

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

@draveness: The label(s) sig/apimachinery cannot be appled. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

In response to this:

/sig apimachinery
/sig scheduling

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@draveness

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

/retest

@draveness draveness marked this pull request as ready for review Sep 11, 2019

@draveness draveness changed the title feat: relex namespace restrictions for critical pod [WIP] feat: relex namespace restrictions for critical pod - PART1 Sep 11, 2019

@draveness draveness changed the title [WIP] feat: relex namespace restrictions for critical pod - PART1 [WIP] feat: relex namespace restrictions for critical pod - part1 Sep 11, 2019

@caesarxuchao

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

/assign @bsalamat

@draveness draveness changed the title [WIP] feat: relex namespace restrictions for critical pod - part1 feat: relex namespace restrictions for critical pod - part1 Sep 13, 2019

@draveness

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.