Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #80048: Fixes mount/unmount paths for migrated inline volumes. Some #82563

Conversation

@leakingtapan
Copy link
Contributor

commented Sep 11, 2019

Cherry pick of #80048 on release-1.15.

#80048: Fixes mount/unmount paths for migrated inline volumes. Some

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

@leakingtapan: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #80048.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

@leakingtapan: This cherry pick PR is for a release branch and has not yet been approved by the Patch Release Team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, please ping the kubernetes/patch-release-team in a comment, after it has been approved by the relevant OWNERS.
For details on the patch release process and schedule, see the Patch Releases page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

@leakingtapan: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Fixes mount/unmount paths for migrated inline volumes. Some minor fix…
…es for GCE specific inline migrated volumes
@leakingtapan

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

@k8s-ci-robot k8s-ci-robot requested review from davidz627 and wongma7 Sep 11, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leakingtapan
To complete the pull request process, please assign saad-ali
You can assign the PR to them by writing /assign @saad-ali in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from msau42 and rootfs Sep 11, 2019

@k8s-ci-robot k8s-ci-robot added sig/storage and removed needs-sig labels Sep 11, 2019

@davidz627

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

@leakingtapan IIRK we did not want to cherry-pick this since it is on an Alpha feature and thus cannot be considered a criticial bug fix (I believe cherry picks are reserved for those).
/cc @tpepper @msau42
to confirm

@k8s-ci-robot k8s-ci-robot requested a review from tpepper Sep 11, 2019

@tpepper

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2019

/kind bug
/priority important-soon
/release-note-none
as per parent PR

@tpepper

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2019

Affirmative, as with the closed #80174 rationale this doesn't feel like our normal critical-urgent bug fix backport, versus accumulating fixes into the release in which the feature goes to beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.