Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update header comment #82565

Open
wants to merge 1 commit into
base: master
from

Conversation

@yiyang5055
Copy link

commented Sep 11, 2019

What type of PR is this?

What this PR does / why we need it:

only update header comment

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

Welcome @yiyang5055!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

Hi @yiyang5055. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yiyang5055

This comment has been minimized.

Copy link
Author

commented Sep 11, 2019

/assign @dchen1107

@yiyang5055

This comment has been minimized.

Copy link
Author

commented Sep 11, 2019

/kind cleanup

@mattjmcnaughton
Copy link
Contributor

left a comment

/lgtm
/ok-to-test

thank you for this fix.

are there any other instances of this header being incorrect that we want to clean up in this diff?

@yiyang5055

This comment has been minimized.

Copy link
Author

commented Sep 11, 2019

@mattjmcnaughton You reminded me that I forgot the same mistake in deviceplugin/v1alpha/api.proto, this is my first PR, i don't know what should i do? close this pr and repull request?

@yiyang5055 yiyang5055 force-pushed the yiyang5055:update-header-comment branch from b8320d8 to ded18e1 Sep 11, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 11, 2019

@yiyang5055

This comment has been minimized.

Copy link
Author

commented Sep 12, 2019

@jiayingz @mindprince need approved, lgtm

@yiyang5055 yiyang5055 requested a review from mattjmcnaughton Sep 12, 2019

@mattjmcnaughton
Copy link
Contributor

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 12, 2019

@jiayingz

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jiayingz, yiyang5055
To complete the pull request process, please assign dchen1107
You can assign the PR to them by writing /assign @dchen1107 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yiyang5055

This comment has been minimized.

Copy link
Author

commented Sep 14, 2019

/assign @dchen1107

@yiyang5055

This comment has been minimized.

Copy link
Author

commented Sep 16, 2019

pinging @dchen1107

@yiyang5055

This comment has been minimized.

Copy link
Author

commented Sep 16, 2019

/assign @Random-Liu need approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.