Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add or fix some errors return statements and ineffassign #82571

Merged

Conversation

@haoshuwei
Copy link
Contributor

commented Sep 11, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

some functions missed the errors return statements, it will lead to a wrong error returned.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: haoshuwei haoshuwei24@gmail.com

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

Hi @haoshuwei. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from jsafrane and rootfs Sep 11, 2019

@k8s-ci-robot k8s-ci-robot added sig/storage and removed needs-sig labels Sep 11, 2019

@haoshuwei

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

/assign @rootfs

@haoshuwei

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

/assign @feiskyer

@xianlubird

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

/ok-to-test

@haoshuwei haoshuwei force-pushed the haoshuwei:fix-ineffassign-in-pkg-controller branch from b7b4552 to f2751ca Sep 12, 2019

@dims

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

/assign @jsafrane
/unassign

@@ -127,7 +127,7 @@ func TestConstructVolumeSpec(t *testing.T) {
t.Errorf("can't find cephfs plugin by name")
}

cephfsSpec, err := plug.(*cephfsPlugin).ConstructVolumeSpec("cephfsVolume", "/cephfsVolume/")
cephfsSpec, _ := plug.(*cephfsPlugin).ConstructVolumeSpec("cephfsVolume", "/cephfsVolume/")

This comment has been minimized.

Copy link
@jsafrane

jsafrane Sep 13, 2019

Member

should we check err, just to be sure?

This comment has been minimized.

Copy link
@haoshuwei

haoshuwei Sep 14, 2019

Author Contributor

yes, it is better to check the err , let me update it.

add or fix some errors return statements and ineffassign
Signed-off-by: haoshuwei <haoshuwei24@gmail.com>

@haoshuwei haoshuwei force-pushed the haoshuwei:fix-ineffassign-in-pkg-controller branch from f2751ca to b752997 Sep 14, 2019

@haoshuwei

This comment has been minimized.

Copy link
Contributor Author

commented Sep 14, 2019

/test pull-kubernetes-integration

@jsafrane

This comment has been minimized.

Copy link
Member

commented Sep 16, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 16, 2019

@feiskyer
Copy link
Member

left a comment

/lgtm
/priority important-soon

@feiskyer

This comment has been minimized.

Copy link
Member

commented Sep 16, 2019

/assign @dims for approval

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2019

@feiskyer: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @dims for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims

This comment has been minimized.

Copy link
Member

commented Sep 16, 2019

/lgtm
/approve

(for hack/)

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, haoshuwei, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ab88ff2 into kubernetes:master Sep 16, 2019

25 checks passed

cla/linuxfoundation haoshuwei authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Skipped.
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.