Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RS expectations for recreate case #82572

Open
wants to merge 3 commits into
base: master
from

Conversation

@tnozicka
Copy link
Contributor

commented Sep 11, 2019

What type of PR is this?
/kind bug
/priority important-soon
/sig apps

What this PR does / why we need it:
With current implementation deleting expectations inside sync loop is error prone.
https://github.com/kubernetes/kubernetes/blob/5823cfc/pkg/controller/replicaset/replica_set.go#L576
If we update the informers faster then the sync loop starts, it will already see the new RS (recreated) and miss the branch when it should delete the expectations for the old one. As a result it will get stuck waiting on the current expectations to timeout or some other external event like deleting the old pods.

This should have been mitigated by seeing the old pods deleted which seem to point to another issue with expectations there. Seeing some weird stuff there around handling expectations - I'll address it in a separate PR.

Which issue(s) this PR fixes:
Fixes #69376

Does this PR introduce a user-facing change?:

NONE

some discussions were also in #72927

/cc @kubernetes/sig-apps-pr-reviews @liggitt @lavalamp

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tnozicka tnozicka force-pushed the tnozicka:fix-rs-expectations branch 2 times, most recently from 35fa529 to efbcee3 Sep 11, 2019

@tnozicka tnozicka force-pushed the tnozicka:fix-rs-expectations branch from efbcee3 to 78fdd0f Sep 11, 2019

@tnozicka

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.