Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: fix pause command in ProxyMode func #82576

Merged

Conversation

@sttts
Copy link
Contributor

commented Sep 11, 2019

The agn image has no pause command, only a pause subcommand of the agn command.

/kind bug

NONE
e2e: fix pause command in ProxyMode func
The agn image has no pause command, only a pause subcommand of the agn command.
@sttts

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

@danwinship
Copy link
Contributor

left a comment

Yes, although this should just be using e2epod.LaunchHostExecPod.

@sttts

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

/retest

@liggitt

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

what test should have been failing because of this bug?

@josiahbjorgaard

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

Bug Triage team on 1.16 release here. Since we have passed code freeze, PRs intended for 1.16 will need to go through approval to be cherry-picked. Since this PR is not flagged critical-urgent, we recommend moving it to milestone 1.17. Cherry-pick deadline for PRs on 1.16 is tomorrow EOD.

@sttts

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

what test should have been failing because of this bug?

I think it is not fatal for the test. Just a warning. Removing milestone.

@sttts sttts removed this from the v1.16 milestone Sep 11, 2019

@timothysc
Copy link
Member

left a comment

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 11, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 08fffda into kubernetes:master Sep 12, 2019

25 checks passed

cla/linuxfoundation sttts authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Skipped.
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.