Propagate and honor http.ErrAbortHandler #82588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
liggitt
force-pushed
the
abort-handler-panic
branch
2 times, most recently
from
f1bebcd
to
c0e66fc
Compare
|
Am fine with the direction. |
liggitt
force-pushed
the
abort-handler-panic
branch
from
c0e66fc
to
b3640ee
Compare
k8s-ci-robot
added
size/M
liggitt
force-pushed
the
abort-handler-panic
branch
from
b3640ee
to
40e4366
Compare
jpbetz
reviewed
Sep 11, 2019
liggitt
force-pushed
the
abort-handler-panic
branch
from
40e4366
to
f174cf8
Compare
k8s-ci-robot
added
size/L
|
updated godocs, added tests |
|
/priority critical-urgent |
k8s-ci-robot
added
the
priority/critical-urgent
k8s-ci-robot
removed
the
needs-priority
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added
release-note
liggitt
force-pushed
the
abort-handler-panic
branch
from
f174cf8
to
4341529
Compare
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
removed
the
lgtm
|
fixed spelling error ( |
liggitt
added
the
lgtm
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 12, 2019
…8-upstream-release-1.16 Automated cherry pick of #82588: Propagate and honor http.ErrAbortHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Alternative to #82586
Fixes #82591
Prevents excessive log spam when proxied connections are closed by the backend.
The http stdlib uses a propagated panic as a sentinel value to indicate the panic is expected and no stack trace should be logged. This PR makes our panic-logging handlers honor that documented sentinel value.
Does this PR introduce a user-facing change?:
/sig api-machinery
/cc @deads2k @sttts