Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the error return from AddPlugin #82594

Merged
merged 1 commit into from Sep 19, 2019

Conversation

@tedyu
Copy link
Contributor

commented Sep 11, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Currently the error return from actualStateOfWorldUpdater.AddPlugin is ignored.

This PR adds the check of the error return.

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@tedyu

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

Copy link
Contributor

left a comment

/lgtm

Thanks!

@saad-ali

This comment has been minimized.

Copy link
Member

commented Sep 18, 2019

/assign @taragu

@@ -112,11 +113,14 @@ func (og *operationGenerator) GenerateRegisterPluginFunc(
}
// We add the plugin to the actual state of world cache before calling a plugin consumer's Register handle
// so that if we receive a delete event during Register Plugin, we can process it as a DeRegister call.
actualStateOfWorldUpdater.AddPlugin(cache.PluginInfo{
err = actualStateOfWorldUpdater.AddPlugin(cache.PluginInfo{

This comment has been minimized.

Copy link
@saad-ali

saad-ali Sep 18, 2019

Member

@taragu I forgot, was there a reason we didn't check for error here?

This comment has been minimized.

Copy link
@taragu

taragu Sep 19, 2019

Member

I can't think of why. I think I must have missed it.

@@ -112,11 +113,14 @@ func (og *operationGenerator) GenerateRegisterPluginFunc(
}
// We add the plugin to the actual state of world cache before calling a plugin consumer's Register handle
// so that if we receive a delete event during Register Plugin, we can process it as a DeRegister call.
actualStateOfWorldUpdater.AddPlugin(cache.PluginInfo{
err = actualStateOfWorldUpdater.AddPlugin(cache.PluginInfo{

This comment has been minimized.

Copy link
@taragu

taragu Sep 19, 2019

Member

I can't think of why. I think I must have missed it.

@taragu

This comment has been minimized.

Copy link
Member

commented Sep 19, 2019

/lgtm

Thanks @tedyu !

Copy link
Member

left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali, tedyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tedyu

This comment has been minimized.

Copy link
Contributor Author

commented Sep 19, 2019

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit 3d897f2 into kubernetes:master Sep 19, 2019
25 checks passed
25 checks passed
cla/linuxfoundation yutedz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Skipped.
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.