Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ipv6 ip allocation method for standard lb #82597

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@aramase
Copy link
Member

commented Sep 11, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
In azure, standard loadbalancers require ipv6 public ip allocation method to be static. This PR checks the loadbalancer SKU and sets the allocation method based on the SKU.

Ref doc - https://docs.microsoft.com/en-us/azure/virtual-network/virtual-network-public-ip-address#create-a-public-ip-address

 If you select IPv6 for the IP version, the assignment method is Dynamic. If you select Standard for SKU, the assignment method is Static.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@aramase

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

/cc @khenidak

@aramase

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

/area provider/azure

@justaugustus

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

This LGTM, but I'll leave Pengfei or Andy to do final review.
/assign @feiskyer @andyzhangx
/retest

@justaugustus

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

/priority important-soon
/milestone v1.17

Copy link
Member

left a comment

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 17, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 31008f7 into kubernetes:master Sep 17, 2019
25 checks passed
25 checks passed
cla/linuxfoundation aramase authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Skipped.
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@aramase aramase deleted the aramase:standard-lb-ipv6 branch Sep 24, 2019
k8s-ci-robot added a commit that referenced this pull request Sep 27, 2019
…7-upstream-release-1.16

Automated cherry pick of #82597: Fix ipv6 ip allocation method for standard lb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.