Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip publishing OpenAPI when spec.preserveUnknownFields is true #82666

Conversation

@liggitt
Copy link
Member

liggitt commented Sep 12, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Restores compatibility with kubectl client-side validation when structural schemas are present in a CRD which sets spec.preserveUnknownFields=true

Manual pick of part of #82653

Does this PR introduce a user-facing change?:

Restores compatibility with kubectl client-side validation when structural schemas are present in a CRD which sets spec.preserveUnknownFields=true

/sig api-machinery
/priority important-soon
/assign @sttts @roycaihw

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Sep 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts

This comment has been minimized.

Copy link
Contributor

sttts commented Sep 12, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 12, 2019
@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Sep 12, 2019

/hold
for #82653 merge

@liggitt liggitt force-pushed the liggitt:skip-publish-preserve-unknown-fields-1.15 branch from 1e131a4 to 237c3db Sep 13, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Sep 13, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Sep 13, 2019

New changes are detected. LGTM label has been removed.

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Sep 13, 2019

rebased

@liggitt liggitt added the lgtm label Sep 13, 2019
@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Sep 13, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 90e2404 into kubernetes:release-1.15 Sep 13, 2019
24 of 25 checks passed
24 of 25 checks passed
tide Not mergeable.
Details
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Skipped.
pull-kubernetes-e2e-gce-alpha-features Skipped.
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Skipped.
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
@roycaihw

This comment has been minimized.

Copy link
Member

roycaihw commented Sep 13, 2019

LGTM

@liggitt liggitt deleted the liggitt:skip-publish-preserve-unknown-fields-1.15 branch Sep 16, 2019
@yue9944882

This comment has been minimized.

Copy link
Member

yue9944882 commented Dec 12, 2019

@liggitt this pull was actually breaking backward-compatibility of openapi-publishing feature. before v1.15.3, we were able to published openapi spec for those CRDs disabled prunning, but this commit tighten the scope that only CRDs enabled pruning can be published :( we should keep compatibility between patch releases (just got burnt by this)

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Dec 12, 2019

1.15.0-1.15.2 broke compatibility with prior versions of kubectl, which was why this was required, to match our documented supported skew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.