Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang scientific notation using hack/update-gofmt.sh #82684

Merged
merged 1 commit into from Sep 13, 2019
Merged

Update golang scientific notation using hack/update-gofmt.sh #82684

merged 1 commit into from Sep 13, 2019

Conversation

davidz627
Copy link
Contributor

/kind cleanup

Looks like golang changed their standard scientific notation to lower case e from E.

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubelet area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 13, 2019
@davidz627
Copy link
Contributor Author

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 13, 2019
@cblecker
Copy link
Member

/lgtm
/approve

This makes it compatible with go1.13+, but is also compatible with the current go1.12 we are building with.

/assign @derekwaynecarr
for approval

FYI @liggitt

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2019
@liggitt
Copy link
Member

liggitt commented Sep 13, 2019

yeah, see golang/go#32580

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, davidz627, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9fa7889 into kubernetes:master Sep 13, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 13, 2019
@davidz627 davidz627 deleted the fix/fmt branch September 13, 2019 17:30
@liggitt liggitt mentioned this pull request Sep 18, 2019
Open
10 tasks
@liggitt liggitt mentioned this pull request Nov 8, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjpotter sjpotter Awaiting requested review from sjpotter

@vishh vishh Awaiting requested review from vishh

Assignees

@cblecker cblecker

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@davidz627 @cblecker @liggitt @k8s-ci-robot @derekwaynecarr