Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow v1 review versions in 1.17+ #82707

Merged
merged 1 commit into from Sep 16, 2019

Conversation

@liggitt
Copy link
Member

liggitt commented Sep 13, 2019

What type of PR is this?
/kind api-change
/kind cleanup
/kind feature

What this PR does / why we need it:
1.16 API servers can understand v1 AdmissionReview and ConversionReview versions, so allow CRDs conversion and admission webhooks to indicate that only v1 reviews should be sent as of 1.17+

Which issue(s) this PR fixes:
Fixes #82023

Does this PR introduce a user-facing change?:

* When registering with a 1.17+ API server, MutatingWebhookConfiguration and ValidatingWebhookConfiguration objects can now request that only `v1` AdmissionReview requests be sent to them. Previously, webhooks were required to support receiving `v1beta1` AdmissionReview requests as well for compatibility with API servers <= 1.15.
* When registering with a 1.17+ API server, a CustomResourceDefinition conversion webhook can now request that only `v1` ConversionReview requests be sent to them. Previously, conversion webhooks were required to support receiving `v1beta1` ConversionReview requests as well for compatibility with API servers <= 1.15.

/sig api-machinery
/cc @jpbetz @roycaihw
/assign @smarterclayton
for API review

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Sep 13, 2019

/priority important-soon

@liggitt liggitt added this to the v1.17 milestone Sep 13, 2019
@liggitt liggitt added this to Bugs/Cleanup/Tests in Admission Webhooks Sep 13, 2019
@liggitt liggitt added this to Bugs/Cleanup/Tests in Custom Resource Definitions Sep 13, 2019
@liggitt liggitt force-pushed the liggitt:allow-1.16-review-versions branch from cd3951b to eedf063 Sep 13, 2019
@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Sep 13, 2019
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Sep 13, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@roycaihw

This comment has been minimized.

Copy link
Member

roycaihw commented Sep 13, 2019

/lgtm
/hold
for API review from @smarterclayton

@smarterclayton

This comment has been minimized.

Copy link
Contributor

smarterclayton commented Sep 16, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Sep 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Sep 16, 2019

/hold cancel

@liggitt liggitt moved this from Assigned to In progress in API Reviews Sep 16, 2019
@liggitt liggitt moved this from In progress to API review completed, 1.17 in API Reviews Sep 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3ef3b6a into kubernetes:master Sep 16, 2019
25 checks passed
25 checks passed
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Skipped.
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@liggitt liggitt deleted the liggitt:allow-1.16-review-versions branch Sep 16, 2019
@liggitt liggitt moved this from Bugs/Cleanup/Tests to Complete in Custom Resource Definitions Sep 17, 2019
@liggitt liggitt moved this from Bugs/Cleanup/Tests to Complete in Admission Webhooks Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.