Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose and use an AddHealthChecks method directly on config #82713

Merged
merged 1 commit into from Sep 16, 2019

Conversation

@logicalhan
Copy link
Contributor

logicalhan commented Sep 14, 2019

What type of PR is this?

/kind bug

What this PR does / why we need it:

KMS and etcd health checks are not being properly added to the livez/readyz endpoints. This fixes that.

Which issue(s) this PR fixes:

Fixes #82712

Resolves issue with /readyz and /livez not including etcd and kms health checks
@logicalhan

This comment has been minimized.

Copy link
Contributor Author

logicalhan commented Sep 14, 2019

/assign @liggitt

@tedyu

This comment has been minimized.

Copy link
Contributor

tedyu commented Sep 14, 2019

/lgtm

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Sep 16, 2019

/priority important-soon
/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Sep 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Sep 16, 2019

thanks, please pick to release-1.16 once merged for inclusion in 1.16.1, and add details as a known issue to #81930

@liggitt liggitt added this to the v1.16 milestone Sep 16, 2019
@liggitt liggitt changed the title expose and use an AddHealthChecks method directly on config [v1.16.1] expose and use an AddHealthChecks method directly on config Sep 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit 61affb3 into kubernetes:master Sep 16, 2019
24 of 25 checks passed
24 of 25 checks passed
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation logicalhan authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Skipped.
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.16, v1.17 Sep 16, 2019
@liggitt liggitt changed the title [v1.16.1] expose and use an AddHealthChecks method directly on config expose and use an AddHealthChecks method directly on config Sep 16, 2019
k8s-ci-robot added a commit that referenced this pull request Sep 20, 2019
…2713-upstream-release-1.16

[v1.16.1] Automated cherry pick of #82713: expose and use an AddHealthChecks method directly on config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.