Differentiate build process for non-amd platforms #82778
Conversation
k8s-ci-robot
added
release-note-none
|
Hi @chendave. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
area/test
sig/testing
|
sorry I'm behind on reviews |
k8s-ci-robot
added
ok-to-test
chendave
force-pushed
the
split_build_scripts
branch
from
20cf449
to
b5cdbc2
Compare
|
@BenTheElder Thanks for picking this up. |
|
@mkumatag thanks for your time on this. |
|
poke @mkumatag , could you take a look at this pls? |
well,! I'm busy today, I will take a look in the next couple of days! |
chendave
force-pushed
the
split_build_scripts
branch
2 times, most recently
from
010788f
to
ba9fc0a
Compare
|
@mkumatag all comments addressed, could you pls take another look? thank you! |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
the
lifecycle/stale
Done |
|
/test pull-kubernetes-integration |
|
@joakimr-axis thanks for the review, all fixed, PTAL again? |
|
/retest |
Looks really nice now, IMO! |
|
verified that this works! here's the log:
```
ubuntu@ip-172-31-81-16:~/go/src/k8s.io/kubernetes/test/images$ make WHAT=apparmor-loader
./image-util.sh build apparmor-loader "docker"
Building image for apparmor-loader OS/ARCH: linux/amd64...
make[1]: Entering directory '/home/ubuntu/go/src/k8s.io/kubernetes/test/images/apparmor-loader'
../image-util.sh bin loader
Unable to find image 'golang:1.15.7' locally
1.15.7: Pulling from library/golang
6e5587ff5efa: Already exists
439dbbb05ea0: Already exists
3b89c8b4e5b2: Already exists
4a53f70a43c3: Already exists
d56052def468: Already exists
0371b45dab95: Already exists
d81d5ca3d230: Already exists
Digest: sha256:c161abf0cde3969e05f6914a86cab804b2b0df515f4ff9570475b25547ba7959
Status: Downloaded newer image for golang:1.15.7
make[1]: Leaving directory '/home/ubuntu/go/src/k8s.io/kubernetes/test/images/apparmor-loader'
~/go/src/k8s.io/kubernetes/_tmp/test-images-build.X4kmL8 ~/go/src/k8s.io/kubernetes/test/images
skip cross-build amd64 on non-supported platform aarch64.
~/go/src/k8s.io/kubernetes/test/images
Building image for apparmor-loader OS/ARCH: linux/arm...
make[1]: Entering directory '/home/ubuntu/go/src/k8s.io/kubernetes/test/images/apparmor-loader'
../image-util.sh bin loader
make[1]: Leaving directory '/home/ubuntu/go/src/k8s.io/kubernetes/test/images/apparmor-loader'
~/go/src/k8s.io/kubernetes/_tmp/test-images-build.UmKtdN ~/go/src/k8s.io/kubernetes/test/images
skip cross-build arm on non-supported platform aarch64.
~/go/src/k8s.io/kubernetes/test/images
Building image for apparmor-loader OS/ARCH: linux/arm64...
make[1]: Entering directory '/home/ubuntu/go/src/k8s.io/kubernetes/test/images/apparmor-loader'
../image-util.sh bin loader
make[1]: Leaving directory '/home/ubuntu/go/src/k8s.io/kubernetes/test/images/apparmor-loader'
~/go/src/k8s.io/kubernetes/_tmp/test-images-build.zU1Lsj ~/go/src/k8s.io/kubernetes/test/images
#1 [internal] load build definition from Dockerfile
#1 sha256:7c4699ae537131bb0f2c400d16759e5047cca38947fd03a15438b5132a32597d
#1 transferring dockerfile: 1.02kB done
#1 DONE 0.0s
#2 [internal] load .dockerignore #3 [internal] load metadata for docker.io/arm64v8/alpine:3.8 #6 [internal] load build context #4 [1/3] FROM docker.io/arm64v8/alpine:3.8@sha256:e802987f152d7826cf929ad4999fb3bb956ce7a30966aeb46c749f9120eaf22c #5 [2/3] RUN apk add apparmor libapparmor --update-cache --repository http://dl-cdn.alpinelinux.org/alpine/edge/testing/ --allow-untrusted && apk add --no-cache musl>1.1.20 --repository http://dl-cdn.alpinelinux.org/alpine/edge/main/ #7 [3/3] ADD loader /usr/bin/loader #8 exporting to image ubuntu@ip-172-31-81-16:~/go/src/k8s.io/kubernetes/test/images$ uname -a ubuntu@ip-172-31-81-16:~/go/src/k8s.io/kubernetes/test/images$ cat /etc/release |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chendave, dims The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
/retest Review the full test history for this PR. Silence the bot with an |
1 similar comment
|
/retest Review the full test history for this PR. Silence the bot with an |
|
/test pull-kubernetes-e2e-kind |
|
/retest Review the full test history for this PR. Silence the bot with an |
|
@dims thanks for verifying this PR, it's great to see this got merged eventually and release me from this long standing changing request. |
reset
binfmt_miscis needn't when the building platform is non-amd64 and thetarget arch is the same as building platform
non-amd64 platform doesn't supported cross-build well, and there is no binary of
qemu-user-staticable to do that, and thus skip the cross-build on non-amd64platform.
Here is what it looks like for apparmor-loader build on ARM64.
Signed-off-by: Dave Chen dave.chen@arm.com
What type of PR is this?
/kind bug
Which issue(s) this PR fixes:
Fixes #82775
Fixes #81920
Special notes for your reviewer:
Does this PR introduce a user-facing change?: