Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Do not query the cloud if dynamic PV has all the labels #82830
This saves one cloud API call in admission plugin. As result, API server latency can go down significantly when creating many PVs and cloud API starts throttling requests.
Special notes for your reviewer:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
I think this is a good tradeoff to make. If the user has chosen to take ownership of these fields, it is their responsibility to set them correctly and they may actually be surprised that we force changed these. If a user isn't certain, then they shouldn't set them. I think we have some flexibility in finding the correct balance between making a user-friendly API and one that is performant.
Added extra heuristics for dynamically provisioned PV vs user provisioned PV: the dynamically provisioned ones have annotation
So now it breaks only PVs created by user that have the annotation dedicated for dynamic provisioning.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing