Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeLifecycleContorller - eviction processing refactor #82884

Merged
merged 1 commit into from Sep 26, 2019

Conversation

@krzysied
Copy link
Contributor

krzysied commented Sep 19, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Cleanup + setup for #81167

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@krzysied

This comment has been minimized.

Copy link
Contributor Author

krzysied commented Sep 19, 2019

/assign @wojtek-t

@krzysied krzysied force-pushed the krzysied:node_controller_cleanup3 branch from 2ced876 to 2f3e846 Sep 19, 2019
@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Sep 19, 2019

@krzysied - the failure of integration seems related to this change

@krzysied

This comment has been minimized.

Copy link
Contributor Author

krzysied commented Sep 20, 2019

/test pull-kubernetes-integration

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Sep 26, 2019

/lgtm
/approve

The test failure is this one: #83182 which failed for me on completely independent PR now.

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 26, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Sep 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzysied, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d8a420c into kubernetes:master Sep 26, 2019
25 checks passed
25 checks passed
cla/linuxfoundation krzysied authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Skipped.
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 26, 2019
@krzysied krzysied deleted the krzysied:node_controller_cleanup3 branch Sep 26, 2019
k8s-ci-robot added a commit that referenced this pull request Mar 10, 2020
…82884-#83248-#83320-#83780-#84445-#81167-upstream-release-1.16

Automated cherry pick of fix for #77733 (NodeLifecycleController is overloading kube-apiserver) into release-1.16
k8s-ci-robot added a commit that referenced this pull request Mar 11, 2020
…81839-#82489-#82884-#83248-#83320-#83780-#84445-#81167-upstream-release-1.15

Automated cherry pick of fix for #77733 (NodeLifecycleController is overloading kube-apiserver) into release-1.15
whypro pushed a commit to whypro/kubernetes that referenced this pull request Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.