Initial deprecation of kubeadm v1beta1 apis #83276

Klaven · 2019-09-29T00:16:51Z

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR deprecates the v1beta1 apies in kubeadm in favor of the v1beta2 apis.
Which issue(s) this PR fixes:

Fixes #

There is no issue filed, was discussed in 18th September 2019 kubeadm office hours when version 1.17 was planned.

Special notes for your reviewer:
I hope this is going on the right path, I looked up /api/apps/v1beta1 was deprecated and kind of just followed along. Please let me know anything else that needs done and I will get it done. Thank you!

Does this PR introduce a user-facing change?:

Action Required: `kubeadm.k8s.io/v1beta1` has been deprecated, you should update your config to use newer non-deprecated API versions.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

neolit123 · 2019-09-29T20:14:18Z

/assign @rosti

neolit123 · 2019-09-29T20:18:01Z

cmd/kubeadm/app/apis/kubeadm/v1beta1/types.go

@@ -113,6 +115,7 @@ type ClusterConfiguration struct {
 	ClusterName string `json:"clusterName,omitempty"`
 }

+// DEPRECATED


i think we should add the message:

DEPRECATED - This group version of X is deprecated by apis/kubeadm/v1beta2/X.

to:

InitConfiguration
JoinConfiguration
ClusterConfiguration

but not have it for the other objects.

+1 for what @neolit123 said

neolit123 · 2019-09-29T20:18:35Z

/kind cleanup
/priority important-longterm

neolit123 · 2019-09-29T20:19:38Z

in the release note:

you should update to use the kubeadm/app/apis/kubeadm/v1beta2

please omit the.

rosti

Thanks @Klaven !
We also need to modify validateSupportedVersion (can be found here) in the following ways:

Remove the allowDeprecated param and consider it always false.
Add the v1beta1 version string to the (now empty) map of deprecated versions.
Instead of returning an error, print a warning, that the version is deprecated and users need to use kubeadm config migrate to switch to latest.

rosti · 2019-09-30T08:59:48Z

cmd/kubeadm/app/apis/kubeadm/v1beta1/types.go

@@ -113,6 +115,7 @@ type ClusterConfiguration struct {
 	ClusterName string `json:"clusterName,omitempty"`
 }

+// DEPRECATED


+1 for what @neolit123 said

Klaven · 2019-10-01T21:47:14Z

* Remove the `allowDeprecated` param and consider it always `false`.

@rosti I am not sure I agree with this. If I did it would let deprecated api be used with init and join. I split the function so that it only returned an error if not allowed, and if allowed it logs a warning. Now that I think about it... it really is not needed anyhow as when you are allowed to use it you are running migrate anyhow and the warning is just going to tell you the same. What do you think?

rosti · 2019-10-02T15:44:39Z

@Klaven the idea is to have beta level APIs working out of the box. No matter if they are deprecated or not. Hence, we need to log a warning.
However, I think, that you are right for the flag. Let's keep it that way, just change the error return into a klog.Warning.

Klaven · 2019-10-04T00:55:10Z

/test pull-kubernetes-e2e-gce-device-plugin-gpu

neolit123 · 2019-10-04T08:40:51Z

/retest

rosti · 2019-10-04T13:04:11Z

cmd/kubeadm/app/util/config/common.go

@@ -72,7 +74,7 @@ func validateSupportedVersion(gv schema.GroupVersion, allowDeprecated bool) erro
 	}

 	if _, present := deprecatedAPIVersions[gvString]; present && !allowDeprecated {
-		return errors.Errorf("your configuration file uses a deprecated API spec: %q. Please use 'kubeadm config migrate --old-config old.yaml --new-config new.yaml', which will write the new, similar spec using a newer API version.", gv.String())
+		klog.Errorf("your configuration file uses a deprecated API spec: %q. Please use 'kubeadm config migrate --old-config old.yaml --new-config new.yaml', which will write the new, similar spec using a newer API version.", gv.String())


s/Errorf/Warningf
Furthermore, no need to call gv.String(), just pass gv, .String() will be called under the hood.

rosti · 2019-10-04T14:22:59Z

Another thing, can you change the release note to something like this?

Action Required: `kubeadm.k8s.io/v1beta1` has been deprecated, you should update your config to use newer non-deprecated API versions.

Klaven · 2019-10-07T01:32:42Z

/test pull-kubernetes-kubemark-e2e-gce-big

rosti

Thanks @Klaven!
/approve
/lgtm

k8s-ci-robot · 2019-10-07T11:05:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Klaven, rosti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~cmd/kubeadm/OWNERS~~ [rosti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fejta-bot · 2019-10-07T14:52:38Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot · 2019-10-07T23:58:39Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot · 2019-10-08T05:13:39Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

k8s-ci-robot requested review from dixudx and yagonobre September 29, 2019 00:17

k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 29, 2019

k8s-ci-robot assigned rosti Sep 29, 2019

neolit123 reviewed Sep 29, 2019

View reviewed changes

rosti reviewed Sep 30, 2019

View reviewed changes

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 1, 2019

Klaven force-pushed the pr_v1beta1_dep branch from 3729066 to 0f78ca1 Compare October 2, 2019 01:09

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 2, 2019

Klaven force-pushed the pr_v1beta1_dep branch 2 times, most recently from ee3e065 to beba0dc Compare October 4, 2019 00:35

rosti reviewed Oct 4, 2019

View reviewed changes

Initial deprecation of kubeadm v1beta1 apis

3a05034

Klaven force-pushed the pr_v1beta1_dep branch from beba0dc to 3a05034 Compare October 6, 2019 23:26

rosti approved these changes Oct 7, 2019

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2019

craiglpeters added this to In progress in Provider Azure Oct 7, 2019

craiglpeters removed this from In progress in Provider Azure Oct 7, 2019

k8s-ci-robot merged commit 6564b34 into kubernetes:master Oct 8, 2019

k8s-ci-robot added this to the v1.17 milestone Oct 8, 2019

floryut mentioned this pull request Jan 8, 2020

Update kubeadm.k8s.io related kinds to use non deprecated api-version kubernetes-sigs/kubespray#5515

Closed

chanwit mentioned this pull request Apr 29, 2020

Support 1.17.x weaveworks/wksctl#174

Merged

pacoxu mentioned this pull request Mar 1, 2021

remove the v1beta1 configuration API kubernetes/kubeadm#2286

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial deprecation of kubeadm v1beta1 apis #83276

Initial deprecation of kubeadm v1beta1 apis #83276

Klaven commented Sep 29, 2019 •

edited

neolit123 commented Sep 29, 2019

neolit123 Sep 29, 2019

rosti Sep 30, 2019

neolit123 commented Sep 29, 2019

neolit123 commented Sep 29, 2019

rosti left a comment

rosti Sep 30, 2019

Klaven commented Oct 1, 2019

rosti commented Oct 2, 2019

Klaven commented Oct 4, 2019

neolit123 commented Oct 4, 2019

rosti Oct 4, 2019

rosti commented Oct 4, 2019 •

edited

Klaven commented Oct 7, 2019

rosti left a comment

k8s-ci-robot commented Oct 7, 2019

fejta-bot commented Oct 7, 2019

fejta-bot commented Oct 7, 2019

fejta-bot commented Oct 8, 2019

Initial deprecation of kubeadm v1beta1 apis #83276

Initial deprecation of kubeadm v1beta1 apis #83276

Conversation

Klaven commented Sep 29, 2019 • edited

neolit123 commented Sep 29, 2019

neolit123 Sep 29, 2019

Choose a reason for hiding this comment

rosti Sep 30, 2019

Choose a reason for hiding this comment

neolit123 commented Sep 29, 2019

neolit123 commented Sep 29, 2019

rosti left a comment

Choose a reason for hiding this comment

rosti Sep 30, 2019

Choose a reason for hiding this comment

Klaven commented Oct 1, 2019

rosti commented Oct 2, 2019

Klaven commented Oct 4, 2019

neolit123 commented Oct 4, 2019

rosti Oct 4, 2019

Choose a reason for hiding this comment

rosti commented Oct 4, 2019 • edited

Klaven commented Oct 7, 2019

rosti left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 7, 2019

fejta-bot commented Oct 7, 2019

fejta-bot commented Oct 7, 2019

fejta-bot commented Oct 8, 2019

Klaven commented Sep 29, 2019 •

edited

rosti commented Oct 4, 2019 •

edited