Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind dns-horizontal containers to linux nodes to avoid Windows scheduling on kubernetes cluster includes linux nodes and windows nodes #83364

Merged
merged 1 commit into from Jan 9, 2020

Conversation

@wawa0210
Copy link
Contributor

wawa0210 commented Oct 1, 2019

Bind dns-horizontal containers to linux nodes to avoid Windows scheduling on kubernetes cluster includes linux nodes and windows nodes

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Bind dns-horizontal containers to linux nodes to avoid Windows scheduling on kubernetes cluster includes linux nodes and windows nodes

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Bind dns-horizontal containers to linux nodes to avoid Windows scheduling on kubernetes cluster includes linux nodes and windows nodes

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 1, 2019

Hi @wawa0210. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wawa0210

This comment has been minimized.

Copy link
Contributor Author

wawa0210 commented Oct 1, 2019

/assign @bowei

@k8s-ci-robot k8s-ci-robot requested review from bowei and MrHohn Oct 1, 2019
…ling on kubernetes cluster includes linux nodes and windows nodes
@wawa0210 wawa0210 force-pushed the wawa0210:zx-dns-horizontal branch from b67be80 to 5459dbf Oct 13, 2019
@bowei

This comment has been minimized.

Copy link
Member

bowei commented Nov 4, 2019

/ok-to-test

@wawa0210

This comment has been minimized.

Copy link
Contributor Author

wawa0210 commented Dec 6, 2019

/assign mrhohn

@bowei

This comment has been minimized.

Copy link
Member

bowei commented Dec 6, 2019

@bowei

This comment has been minimized.

Copy link
Member

bowei commented Dec 6, 2019

Would like to have a comment from sig-windows that this makes sense.

@wawa0210

This comment has been minimized.

Copy link
Contributor Author

wawa0210 commented Dec 7, 2019

Would like to have a comment from sig-windows that this makes sense.

@liggitt @PatrickLang

Hi guys, can you help review this pr. My mistake, the submission of months ago, has not been followed up

Copy link
Member

andyzhangx left a comment

/lgtm

@pires
pires approved these changes Dec 7, 2019
Copy link
Member

pires left a comment

/lgtm

@pires

This comment has been minimized.

Copy link
Member

pires commented Dec 7, 2019

Any deployment of official container images that are Linux-only should have such a nodeSelector.

@wawa0210

This comment has been minimized.

Copy link
Contributor Author

wawa0210 commented Dec 7, 2019

Any deployment of official container images that are Linux-only should have such a nodeSelector.

Yeap, so I added this nodeSelector to other official components of k8s to avoid the Linux container scheduling to windows

@wawa0210

This comment has been minimized.

Copy link
Contributor Author

wawa0210 commented Jan 9, 2020

@bowei @MrHohn Can you approve this pr ? thanks so much

@PatrickLang

This comment has been minimized.

Copy link
Contributor

PatrickLang commented Jan 9, 2020

/lgtm
We've been promoting nodeSelectors as a best practice

@MrHohn
MrHohn approved these changes Jan 9, 2020
Copy link
Member

MrHohn left a comment

Thanks!
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 9, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, wawa0210

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fc98aa5 into kubernetes:master Jan 9, 2020
11 of 15 checks passed
11 of 15 checks passed
pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
pull-kubernetes-verify Job triggered.
Details
cla/linuxfoundation wawa0210 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 9, 2020
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 9, 2020

@wawa0210: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce 5459dbf link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wawa0210 wawa0210 deleted the wawa0210:zx-dns-horizontal branch Jan 10, 2020
@wawa0210 wawa0210 mentioned this pull request Jan 17, 2020
6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.