Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ipallocator in favor of k/utils net package #83422

Merged
merged 1 commit into from Oct 22, 2019

Conversation

@yastij
Copy link
Member

yastij commented Oct 2, 2019

Signed-off-by: Yassine TIJANI ytijani@vmware.com

What type of PR is this?

/kind cleanup
/priority important-soon

What this PR does / why we need it: This removes some of the ipallocator in favor of k/utils's net package, this will help us move kubeadm out-of-tree

Which issue(s) this PR fixes: ref #1600

Special notes for your reviewer:

/assign @neolit123 @liggitt

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@yastij

This comment has been minimized.

Copy link
Member Author

yastij commented Oct 2, 2019

/retest

@fedebongio

This comment has been minimized.

Copy link
Contributor

fedebongio commented Oct 3, 2019

/assign @jennybuckley

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Oct 4, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 4, 2019
pkg/master/services.go Outdated Show resolved Hide resolved
@fabriziopandini

This comment has been minimized.

Copy link
Member

fabriziopandini commented Oct 13, 2019

/lgtm
For the kubeadm part
@yastij many thanks for this work!

@aojea

This comment has been minimized.

Copy link
Member

aojea commented Oct 13, 2019

/cc

@k8s-ci-robot k8s-ci-robot requested a review from aojea Oct 13, 2019
@yastij yastij force-pushed the yastij:remove-ipallocator branch from a5dc3f8 to f37b173 Oct 22, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 22, 2019
@yastij

This comment has been minimized.

Copy link
Member Author

yastij commented Oct 22, 2019

@liggitt - this should be ready to go

pkg/master/services.go Outdated Show resolved Hide resolved
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
@yastij yastij force-pushed the yastij:remove-ipallocator branch from f37b173 to f984b4c Oct 22, 2019
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Oct 22, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 22, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, neolit123, yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9fa1bc8 into kubernetes:master Oct 22, 2019
15 checks passed
15 checks passed
cla/linuxfoundation yastij authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.