Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix double counting issue for request metrics on timeout. #83427
Currently we record request metrics during the normal request flow; we also manually invoke
This PR also renames the
What type of PR is this?
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Currently we record request metrics during the normal request flow and we also manually invoke `Record` in the timeout handler to record timeouts. This means that we effectively double count whenever we timeout. This PR renames the `Record` function to `RecordRequestError` to more accurately reflect the intended side-effect of the function call. Change-Id: Ie37fd0c1e501bd525640a434433d364a5fd6dde2
@logicalhan: The label(s)
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Oh, yes. I will try this as soon as possible. As mentioned by @logicalhan , we will probably need a manual PR to pick this fix back to 1.15 and 1.14.
According to kubernetes version policy, I think 1.13 is no longer maintained, so it wouldn't happen on 1.13.