Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote StartupProbe to beta for 1.18 #83437

Merged
merged 1 commit into from Dec 20, 2019

Conversation

@matthyx
Copy link
Contributor

matthyx commented Oct 3, 2019

Promotes the StartupProbe feature (health check) to beta for the 1.18 release.
Relates to kubernetes/enhancements#950

Promote StartupProbe to beta for 1.18 release
@matthyx

This comment has been minimized.

Copy link
Contributor Author

matthyx commented Oct 3, 2019

/kind feature
/priority important-soon
/sig node

@matthyx

This comment has been minimized.

Copy link
Contributor Author

matthyx commented Oct 3, 2019

/assign @derekwaynecarr

@odinuge

This comment has been minimized.

Copy link
Member

odinuge commented Oct 3, 2019

Hi @matthyx!

Thanks for your work on the StartupProbe. The e2e tests for StartupProbe are failing atm., so it would be nice if you could take a look at the issue. There is also a proposed PR.

@matthyx

This comment has been minimized.

Copy link
Contributor Author

matthyx commented Oct 3, 2019

There is also a proposed PR.

Well, since I want to move it out of alpha, the listed PR could be merged just after this one?
@liggitt what's your opinion?

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Oct 3, 2019

@liggitt what's your opinion?

I don't have a lot of context on it, but these are the types of questions we'd need to answer:

  • is there feedback on use of the feature?
  • is there evidence there are no scale issues introduced by it?
@matthyx

This comment has been minimized.

Copy link
Contributor Author

matthyx commented Oct 3, 2019

I plan to use it on a small cluster, once my admins find how to add the flag with Juju...

For the scale, don't we have some tests from sig-scaling?

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Oct 3, 2019

For the scale, don't we have some tests from sig-scaling?

we have scale tests, but they would need to be updated (or new tests added) to include use of startup probe

@matthyx

This comment has been minimized.

Copy link
Contributor Author

matthyx commented Oct 3, 2019

to include use of startup probe

ok, I can add these to my branch, and then prow will run them to validate the PR?

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Oct 3, 2019

I can add these to my branch, and then prow will run them to validate the PR?

I'd recommend checking with @kubernetes/sig-scalability-pr-reviews. I don't think all scale tests are available as presubmits

@matthyx

This comment has been minimized.

Copy link
Contributor Author

matthyx commented Oct 3, 2019

Dear scalability team, which tests should I modify to include a startupProbe into scalability assessments?
/cc @kubernetes/sig-scalability-pr-reviews

@matthyx

This comment has been minimized.

Copy link
Contributor Author

matthyx commented Oct 3, 2019

@matthyx

This comment has been minimized.

Copy link
Contributor Author

matthyx commented Oct 4, 2019

/milestone v1.17

@matthyx

This comment has been minimized.

Copy link
Contributor Author

matthyx commented Dec 12, 2019

one nit on the feature godoc

Done, thanks @liggitt !

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 12, 2019

ah, forgot the API doc includes the feature state:

	// This is an alpha feature enabled by the StartupProbe feature flag.
	// More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes
	// +optional
	StartupProbe *Probe `json:"startupProbe,omitempty" protobuf:"bytes,22,opt,name=startupProbe"`

will need to update that to beta and run make update to regenerate docs/openapi, etc

@matthyx matthyx force-pushed the matthyx:startupprobe-beta branch from 307eb78 to 49f5c4c Dec 12, 2019
@matthyx

This comment has been minimized.

Copy link
Contributor Author

matthyx commented Dec 12, 2019

will need to update that to beta

@liggitt done, thanks a lot for you sharp eye!

api/openapi-spec/swagger.json Outdated Show resolved Hide resolved
@matthyx matthyx force-pushed the matthyx:startupprobe-beta branch from 49f5c4c to 94d313a Dec 12, 2019
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 12, 2019

/lgtm
/approve
for API changes

/hold for node approval, unhold when ready

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, matthyx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matthyx matthyx force-pushed the matthyx:startupprobe-beta branch from 94d313a to 6603f41 Dec 15, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 15, 2019
@matthyx

This comment has been minimized.

Copy link
Contributor Author

matthyx commented Dec 15, 2019

@liggitt can you LGTM again? I had to resolve a conflict in swagger.json.

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 15, 2019
@dims

This comment has been minimized.

Copy link
Member

dims commented Dec 15, 2019

/retest

@matthyx

This comment has been minimized.

Copy link
Contributor Author

matthyx commented Dec 16, 2019

/test pull-kubernetes-e2e-gce

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 16, 2019

flake #86181

@matthyx

This comment has been minimized.

Copy link
Contributor Author

matthyx commented Dec 20, 2019

/unhold

@matthyx

This comment has been minimized.

Copy link
Contributor Author

matthyx commented Dec 20, 2019

/test pull-kubernetes-e2e-gce

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Dec 20, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot k8s-ci-robot merged commit 9fa1e00 into kubernetes:master Dec 20, 2019
16 of 17 checks passed
16 of 17 checks passed
tide Not mergeable. Retesting: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation matthyx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 20, 2019
@matthyx matthyx deleted the matthyx:startupprobe-beta branch Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.