Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hyperkube from release artifacts #83454

Conversation

@dims
Copy link
Member

commented Oct 3, 2019

Related to #81760

Just like what we did with cloud-controller-manager, this serves as a signal for folks that hyperkube will go to a new repository and will no longer be available from k/k.

Change-Id: Ie09248d6fc688ffffbeb0271824817a5129346a0

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

hyperkube will now be available in a new github repository and will not be included in the kubernetes release from 1.17 onwards

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Change-Id: Ie09248d6fc688ffffbeb0271824817a5129346a0
@dims dims force-pushed the dims:cleanup-hyperkube-from-release-artifacts branch from 49eb7ed to 138571b Oct 3, 2019
@dims

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@dims dims changed the title [WIP] Remove hyperkube from release artifacts Remove hyperkube from release artifacts Oct 4, 2019
@dims

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

/priority important-soon

@dims

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

@dims

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

1 similar comment
@dims

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@dims

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

/milestone v1.17
/sig release
/assign @justaugustus

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 4, 2019
Copy link
Contributor

left a comment

/approve

@jbeda

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2019

/approve

sigh I had dreams for hyperkube but never made it happen.

Copy link
Member

left a comment

/lgtm
/approve
/hold

@kubernetes/release-engineering: FYI -- this will change the release artifacts.

@dims

This comment has been minimized.

Copy link
Member Author

commented Oct 5, 2019

@justaugustus @tpepper PTAL and remove /hold if appropriate.

@justaugustus

This comment has been minimized.

Copy link
Member

commented Oct 5, 2019

Thanks for pouncing on this, @dims!
/lgtm
/approve
/hold cancel

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, dims, fejta, jbeda, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7c540ec into kubernetes:master Oct 5, 2019
17 checks passed
17 checks passed
cla/linuxfoundation dims authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@dims dims referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.