Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit of test/* OWNERS files #83587

Merged
merged 1 commit into from Oct 11, 2019

Conversation

@timothysc
Copy link
Member

commented Oct 7, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
I did an audit of the OWNERS files under test/* and updated according to looking at rough github data over the last ~6-ish-months. No approvers have been removed, they've only been shuffled to emeritus

Which issue(s) this PR fixes:

xref: kubernetes/community#1808
xref: kubernetes/community#4149

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/assign @dims @mrbobbytables

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2019

@timothysc: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

/release-note-none

@ncdc

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

My move LGTM

@timothysc

This comment has been minimized.

Copy link
Member Author

commented Oct 7, 2019

@dims we should timeout at a couple of weeks b/c it was clear from some folks github history that they have moved on.

@rramkumar1

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

LGTM for my change

@@ -5,4 +5,5 @@ reviewers:
- cblecker
approvers:
- cblecker
- rmmh

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Oct 7, 2019

Member

cc @cblecker -- I'd like to swap in on this one rather than have n=1, I think I already have test/ via an alias and I'm already in reviewers / have sent a PR or two to this.

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Oct 7, 2019

Member

there's also a related directory in third_party/ that should be updated (though understandable if it's another PR)
https://github.com/kubernetes/kubernetes/blob/master/third_party/go-srcimporter/OWNERS

This comment has been minimized.

Copy link
@cblecker

cblecker Oct 8, 2019

Member

I'm okay with adding @BenTheElder , but I'm also okay with it being done in a follow up.

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Oct 16, 2019

Member

filed #84020 to follow up 😄

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

thanks for doing this.

suggestion: it might also be a good idea to audit users in OWNERS_ALIASES aliases entries that transitively are reviewers / approvers here (can certainly be another PR rather than complicating this one, but wanted to mention...)

@mrbobbytables

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

suggestion: it might also be a good idea to audit users in OWNERS_ALIASES aliases entries that transitively are reviewers / approvers here (can certainly be another PR rather than complicating this one, but wanted to mention...)

@BenTheElder I'll be sending a PR and tagging groups about it next week. 👍

@stevesloka

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

LGTM for my change

@timothysc

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2019

@BenTheElder

it might also be a good idea to audit users in OWNERS_ALIASES aliases entries that transitively are reviewers / approvers here (can certainly be another PR rather than complicating this one, but wanted to mention...

Yes, my plan is to do this in chunks till I have enough data, then update aliases for *, but "baby-steps".

@xichengliudui

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

I'm sorry about that, because most of my energy is focused on kubernetes/website repo.

@timothysc

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2019

Hmm I can no longer skip tests, this seems wasteful :-(

/test pull-kubernetes-e2e-gce-100-performance
/test pull-kubernetes-kubemark-e2e-gce-big
/test pull-kubernetes-conformance-kind-ipv6
/test pull-kubernetes-conformance-image-test

@timothysc

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2019

/retest

@timothysc

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2019

@BenTheElder ^ me thinks the tests are flaking.

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

Non blocking tests shouldn't block merge and should be skippable.

The conformance image jobs are all rather flaky, something to do with how the image is run.

The scale jobs probably hit #83493 (comment)

Copy link
Member

left a comment

/lgtm
/approve

@@ -5,4 +5,5 @@ reviewers:
- cblecker
approvers:
- cblecker
- rmmh

This comment has been minimized.

Copy link
@cblecker

cblecker Oct 8, 2019

Member

I'm okay with adding @BenTheElder , but I'm also okay with it being done in a follow up.

@cblecker

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

/skip

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

/skip
EDIT: jinx @cblecker 🙃

@cblecker

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

As for moving on removing inactive folks, if they haven't been active in that long, I'm fine with moving quickly if there is consensus among other owners. If the person wants to come back, they are only a PR away from doing that.

Suggestion: 72 hour lazy consensus of test/ owners. WDYT, @timothysc ?

@timothysc

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2019

Suggestion: 72 hour lazy consensus of test/ owners.

sgtm

@timothysc timothysc force-pushed the timothysc:testing-OWNERS branch from 718e7d3 to 9705584 Oct 10, 2019
@k8s-ci-robot k8s-ci-robot added area/conformance and removed lgtm labels Oct 10, 2019
@timothysc

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2019

rebased + timeout
/hold cancel
/skip
@cblecker ^ for lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

@timothysc: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-conformance-image-test 9705584 link /test pull-kubernetes-conformance-image-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cblecker

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

/lgtm
/approve
/skip

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 10, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 242d806 into kubernetes:master Oct 11, 2019
19 checks passed
19 checks passed
cla/linuxfoundation timothysc authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
ohsewon added a commit to ohsewon/kubernetes that referenced this pull request Oct 16, 2019
Audit of test/* OWNERS files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.