Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[migration phase 1] PodMatchNodeSelector/NodAffinity as filter plugin #83660

Merged

Conversation

@wgliang
Copy link
Member

commented Oct 9, 2019

What type of PR is this?

/kind cleanup

/sig scheduling
/priority important-soon

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #83633

Special notes for your reviewer:
/assign @ahg-g

Does this PR introduce a user-facing change?:

[migration phase 1] PodMatchNodeSelector/NodAffinity as filter plugin

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE
@k8s-ci-robot k8s-ci-robot requested review from draveness and hex108 Oct 9, 2019
@wgliang wgliang force-pushed the wgliang:scheduler-v2/pod-match-node-selector branch 4 times, most recently from 98cec7c to dc22259 Oct 9, 2019
@k8s-ci-robot k8s-ci-robot added size/XL and removed size/M labels Oct 10, 2019
@wgliang wgliang force-pushed the wgliang:scheduler-v2/pod-match-node-selector branch from dc22259 to 8129d99 Oct 10, 2019
@wgliang

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2019

/test pull-kubernetes-e2e-gce

@wgliang

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2019

@ahg-g Ready for review. Thanks.

@ahg-g

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

Thanks Leon, lets names this NodeAffinity

/cc @alculquicondor @Huang-Wei

@wgliang wgliang force-pushed the wgliang:scheduler-v2/pod-match-node-selector branch from 8129d99 to acfa519 Oct 11, 2019
@wgliang wgliang force-pushed the wgliang:scheduler-v2/pod-match-node-selector branch from acfa519 to c62617a Oct 11, 2019
@wgliang

This comment has been minimized.

Copy link
Member Author

commented Oct 11, 2019

@ahg-g Rebased and Ready for review. Thanks.

@ahg-g

This comment has been minimized.

Copy link
Member

commented Oct 11, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 11, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, wgliang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahg-g

This comment has been minimized.

Copy link
Member

commented Oct 11, 2019

/test pull-kubernetes-e2e-kind

@fejta-bot

This comment has been minimized.

Copy link

commented Oct 11, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

3 similar comments
@fejta-bot

This comment has been minimized.

Copy link

commented Oct 11, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

commented Oct 11, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

commented Oct 12, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@wgliang wgliang force-pushed the wgliang:scheduler-v2/pod-match-node-selector branch from c62617a to 3b39560 Oct 12, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 12, 2019
@wgliang

This comment has been minimized.

Copy link
Member Author

commented Oct 12, 2019

/test pull-kubernetes-kubemark-e2e-gce-big
/test pull-kubernetes-e2e-gce

@wgliang wgliang force-pushed the wgliang:scheduler-v2/pod-match-node-selector branch from 3b39560 to 0a1808a Oct 12, 2019
@wgliang

This comment has been minimized.

Copy link
Member Author

commented Oct 12, 2019

Nedd LGTM form you. @ahg-g @liu-cong Thanks.

@ahg-g

This comment has been minimized.

Copy link
Member

commented Oct 12, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit becc1b9 into kubernetes:master Oct 12, 2019
14 of 15 checks passed
14 of 15 checks passed
tide Not mergeable.
Details
cla/linuxfoundation wgliang authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 12, 2019
ohsewon added a commit to ohsewon/kubernetes that referenced this pull request Oct 16, 2019
…ch-node-selector

[migration phase 1] PodMatchNodeSelector/NodAffinity as filter plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.