Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add warning when --certificate-key is set and --control-plane is not. #83661
What type of PR is this?
What this PR does / why we need it:
Print warning when
For example, when users try to download certs via
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Hi @jfbai. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
rosti left a comment
Thanks @jfbai !
i would prefer a different solution instead of the flag mixture warning.
this would make the
fabriziopandini left a comment
@jfbai thanks for this contribution
I only added a suggestion to make the check/the warning more generic, then lgtm from my side
@fabriziopandini Thanks a lot and your comment has been fixed. :)
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing