Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[migration phase 1] PodFitsHost as filter plugin #83662

Merged
merged 1 commit into from Oct 11, 2019

Conversation

@wgliang
Copy link
Member

commented Oct 9, 2019

What type of PR is this?
/kind cleanup

/sig scheduling
/priority important-soon

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #83631

Special notes for your reviewer:
/assign @ahg-g

Does this PR introduce a user-facing change?:

[migration phase 1] PodFitsHost as filter plugin

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE
Copy link
Member

left a comment

can you please add a unit test file podfitshost_test.go and copy podfitshost unit tests from predicates_test.go. I am doing that right now for taint and toleration predicate.

@ahg-g

This comment has been minimized.

Copy link
Member

commented Oct 9, 2019

can you please add a unit test file podfitshost_test.go and copy podfitshost unit tests from predicates_test.go. I am doing that right now for taint and toleration predicate.

859f6f1

@wgliang wgliang force-pushed the wgliang:scheduler-v2/pod-fits-host branch from c9b274f to 38552c9 Oct 9, 2019
@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Oct 9, 2019
Copy link
Member

left a comment

we need to register a producer and mapping, and fix the compatibility tests as well.

pkg/scheduler/algorithm/predicates/predicates_test.go Outdated Show resolved Hide resolved
@wgliang wgliang force-pushed the wgliang:scheduler-v2/pod-fits-host branch 5 times, most recently from 7f66884 to 4fd609d Oct 10, 2019
@wgliang

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2019

@ahg-g Ready for review. Thanks.

@ahg-g

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

Thanks Leon, since we are dropping the noun "host", lets name this plugin simply NodeName

@alculquicondor @Huang-Wei who I have discussed the naming with as well.

@wgliang wgliang force-pushed the wgliang:scheduler-v2/pod-fits-host branch from 4fd609d to 148d607 Oct 11, 2019
@wgliang

This comment has been minimized.

Copy link
Member Author

commented Oct 11, 2019

Too tired to resolve conflicts frequently. (crying...) :)

@wgliang wgliang force-pushed the wgliang:scheduler-v2/pod-fits-host branch from 148d607 to b916733 Oct 11, 2019
@ahg-g

This comment has been minimized.

Copy link
Member

commented Oct 11, 2019

/lgtm
/approve

Thanks Leon!

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 11, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, wgliang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit afa394b into kubernetes:master Oct 11, 2019
14 of 15 checks passed
14 of 15 checks passed
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation wgliang authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 11, 2019
ohsewon added a commit to ohsewon/kubernetes that referenced this pull request Oct 16, 2019
…s-host

[migration phase 1] PodFitsHost as filter plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.