Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scheduler): expose SharedInformerFactory to the framework handle #83663

Merged

Conversation

@draveness
Copy link
Member

commented Oct 9, 2019

/kind feature
/sig scheduling
/priority important-soon

What this PR does / why we need it:

Which issue(s) this PR fixes:

ref: #83523

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Expose SharedInformerFactory in the framework handle

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@draveness

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2019

/assign @ahg-g

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Oct 10, 2019
@draveness

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2019

/retest

@draveness draveness requested a review from ahg-g Oct 10, 2019
@draveness draveness force-pushed the draveness:feature/add-shared-informers-factory branch from 4a5a833 to 9cd9168 Oct 10, 2019
@ahg-g

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

Thanks please squash.

/approve
/assign @msau42 for volume-related tests

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

@ahg-g: GitHub didn't allow me to assign the following users: for, volume-related, tests.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Thanks please squash.

/approve
/assign @msau42 for volume-related tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@draveness draveness force-pushed the draveness:feature/add-shared-informers-factory branch from 9cd9168 to d7db0e2 Oct 10, 2019
@draveness

This comment has been minimized.

Copy link
Member Author

commented Oct 10, 2019

Thanks please squash.

done

@ahg-g

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 10, 2019
@ahg-g

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

@draveness: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration d7db0e2 link /test pull-kubernetes-integration
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

this seems like a legitimate failure, we should look closely into it.

@ahg-g

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

/hold

@msau42

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

/approve
/lgtm cancel
to look into test failures

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 10, 2019
@ahg-g

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

/test pull-kubernetes-integration

1 similar comment
@ahg-g

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

/test pull-kubernetes-integration

@draveness draveness force-pushed the draveness:feature/add-shared-informers-factory branch from d7db0e2 to ee4dec6 Oct 11, 2019
@draveness

This comment has been minimized.

Copy link
Member Author

commented Oct 11, 2019

/approve
/lgtm cancel
to look into test failures

https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-kubernetes-integration-master/1179256637836234754

https://testgrid.k8s.io/google-unit#integration-master&include-filter-by-regex=NodePIDPre

It was a flaky test which fails since 10-02 (at least) when this PR wasn't opened. Please take another look, the previous approve does not work as expected.

@ahg-g

This comment has been minimized.

Copy link
Member

commented Oct 11, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 11, 2019
@ahg-g

This comment has been minimized.

Copy link
Member

commented Oct 11, 2019

/hold cancel

@msau42

This comment has been minimized.

Copy link
Member

commented Oct 11, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, draveness, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c980000 into kubernetes:master Oct 11, 2019
16 checks passed
16 checks passed
cla/linuxfoundation draveness authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 11, 2019
ohsewon added a commit to ohsewon/kubernetes that referenced this pull request Oct 16, 2019
…-informers-factory

feat(scheduler): expose SharedInformerFactory to the framework handle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.