Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor kubelet ut with metrics testutil #83664

Conversation

@RainbowMango
Copy link
Member

commented Oct 9, 2019

What type of PR is this?
/kind feature
/priority important-soon

What this PR does / why we need it:
Refactor TestRunningPodAndContainerCount test case with testutils.

And it's also on the way to remove direct reference to Prometheus.

Which issue(s) this PR fixes:
Refer kubernetes/enhancements#1238.

Special notes for your reviewer:
To get metrics stability into Beta, we will make it illegal to directly import prometheus methods in Kubernetes components.

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

RainbowMango added 2 commits Oct 9, 2019
 - Update bazel by hack/update-bazel.sh
@RainbowMango RainbowMango changed the title Pr refactor kubelet ut with metrics testutil Refactor kubelet ut with metrics testutil Oct 9, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RainbowMango
To complete the pull request process, please assign random-liu
You can assign the PR to them by writing /assign @random-liu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from tmrts and vishh Oct 9, 2019
@RainbowMango RainbowMango referenced this pull request Oct 9, 2019
15 of 19 tasks complete
@RainbowMango

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2019

/assign @Random-Liu

@RainbowMango

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2019

@k8s-ci-robot k8s-ci-robot requested a review from logicalhan Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.