Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #79370: Migrate TaintManager to use watch for listing pods instead of #83666

Conversation

@mm4tt
Copy link
Contributor

commented Oct 9, 2019

Cherry pick of #79370 on release-1.14.

#79370: Migrate TaintManager to use watch for listing pods instead of

For details on the cherry pick process, see the cherry pick requests page.

NONE
…ve listing pods call.
@mm4tt

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

We (sig-scalability) believe that the performance impact of this PR is so significant for large clusters that it should be patched into older releases.
Overall the patch translates to much more stable large clusters, especially during start-up phase and when clusters are scaled up. The fix turned out to be crucial for Cluster Autoscaler to work at a bigger scale.

Slack discussion link where sig-release supported the cherry-pick given that we run adhoc tests can be found here

The tests were run by @krzysied, here is a summary:


Comparison of original kubernetes release 1.14 vs release 1.14 + taint manager fix.
Both versions were tested using density performance test.

List calls (purple line is client=node-controller):

  • branch release-1.14 (bdc7ad2)
    1
  • branch release-1.14 + cherry-pick (#79370)
    2

##Call latency:

  • branch release-1.14 (bdc7ad2)
    3
  • branch release-1.14 + cherry-pick (#79370)
    4

Allocation rate:

  • branch release-1.14 (bdc7ad2)
    5
  • branch release-1.14 + cherry-pick (#79370)
    6
@mm4tt

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

/cc @wojtek-t

@k8s-ci-robot k8s-ci-robot requested a review from wojtek-t Oct 9, 2019
@mm4tt

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

/retest

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mm4tt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fc598a3 into kubernetes:release-1.14 Oct 10, 2019
11 checks passed
11 checks passed
cla/linuxfoundation mborsz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.