Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scheduler): expose SharedSchedulerListers in framework handle #83670

Conversation

@draveness
Copy link
Member

commented Oct 9, 2019

/kind feature
/sig scheduling
/priority important-soon

What this PR does / why we need it:

Which issue(s) this PR fixes:

ref: #83523

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Expose SharedSchedulerListers in the framework handle

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: draveness
To complete the pull request process, please assign bsalamat
You can assign the PR to them by writing /assign @bsalamat in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from hex108 and resouer Oct 9, 2019
@draveness

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2019

/assign @ahg-g

@ahg-g

This comment has been minimized.

Copy link
Member

commented Oct 11, 2019

/assign @alculquicondor

Aldo, you created #80372 regarding where to put the scheduler-specific listers, I think it is important to address this now since we want to expose it in the FrameworkHandler.

We need a way of doing this that allows CA, Kubelet and such to create a framework instance without needing to instantiate structs defined in scheduler/internal.

It might be the case that we need to move cache out of internal and define the listers under scheduler/framework? or may be we want to stick with the older model: CA would create a full scheduler (scheduler.New), and we expose an interface through the scheduler for CA to run the filters?

@alculquicondor

This comment has been minimized.

Copy link
Member

commented Oct 11, 2019

Indeed, I'll reactivate the discussion there.

@draveness

This comment has been minimized.

Copy link
Member Author

commented Oct 22, 2019

/close

superseded by #84164

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 22, 2019

@draveness: Closed this PR.

In response to this:

/close

superseded by #84164

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@draveness draveness deleted the draveness:feature/add-SharedSchedulerListers-to-framework-handle branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.