Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(scheduler): expose SharedSchedulerListers in framework handle #83670
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
[APPROVALNOTIFIER] This PR is NOT APPROVED
The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
Aldo, you created #80372 regarding where to put the scheduler-specific listers, I think it is important to address this now since we want to expose it in the FrameworkHandler.
We need a way of doing this that allows CA, Kubelet and such to create a framework instance without needing to instantiate structs defined in scheduler/internal.
It might be the case that we need to move cache out of internal and define the listers under scheduler/framework? or may be we want to stick with the older model: CA would create a full scheduler (scheduler.New), and we expose an interface through the scheduler for CA to run the filters?