Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix golint errors in pkg/controller/namespace #83673

Open

Conversation

@cristiandima
Copy link
Contributor

commented Oct 9, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fix golint errors in pkg/controller/namespace (part of broader golint effort).

Which issue(s) this PR fixes:

Ref #68026

Does this PR introduce a user-facing change?:

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

Hi @cristiandima. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cristiandima

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

/sig sig/api-machinery

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

@cristiandima: The label(s) sig/sig/api-machinery cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

In response to this:

/sig sig/api-machinery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cristiandima

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

/sig api-machinery

@cristiandima

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

/priority backlog

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cristiandima
To complete the pull request process, please assign deads2k
You can assign the PR to them by writing /assign @deads2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cristiandima

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

/assign @deads2k

Copy link
Contributor

left a comment

/ok-to-test
/lgtm

I think avoiding the stutter here makes sense.

@cristiandima

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@cristiandima

This comment has been minimized.

Copy link
Contributor Author

commented Oct 10, 2019

/test pull-kubernetes-e2e-gce

@roycaihw

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

/assign @cheftako

Copy link
Member

left a comment

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.