Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prometheus reference from storage #83678

Conversation

@RainbowMango
Copy link
Member

commented Oct 9, 2019

What type of PR is this?
/kind feature
/priority important-soon

What this PR does / why we need it:
Remove direct reference to Prometheus.

To get metrics stability into Beta, we will make it illegal to directly import prometheus methods in Kubernetes components.

Which issue(s) this PR fixes:
Refer kubernetes/enhancements#1238

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@RainbowMango

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2019

/assign @lavalamp

@roycaihw

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

@k8s-ci-robot k8s-ci-robot requested a review from wenjiaswe Oct 10, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: jktomer.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @wenjiaswe @jktomer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jktomer

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

LGTM (but mine doesn't count yet, you'll need an /lgtm from someone else)

@RainbowMango

This comment has been minimized.

Copy link
Member Author

commented Oct 14, 2019

ping @lavalamp and
/assign @wojtek-t

#83837 rely on this.

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Oct 14, 2019

/lgtm
/approve

@RainbowMango

This comment has been minimized.

Copy link
Member Author

commented Oct 14, 2019

/test pull-kubernetes-dependencies
Can't access the logs.

@RainbowMango RainbowMango force-pushed the RainbowMango:pr_remove_prometheus_reference_from_storage branch from ee9ed5a to 53f448f Oct 14, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 14, 2019
@wojtek-t

This comment has been minimized.

Copy link
Member

commented Oct 14, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 14, 2019
- Update bazel by hack/update-bazel.sh
- Update vendor by hack/update-vendor.sh
@RainbowMango RainbowMango force-pushed the RainbowMango:pr_remove_prometheus_reference_from_storage branch from 53f448f to 6764bf3 Oct 14, 2019
@k8s-ci-robot k8s-ci-robot added area/dependency and removed lgtm labels Oct 14, 2019
@RainbowMango

This comment has been minimized.

Copy link
Member Author

commented Oct 14, 2019

@wojtek-t
I made a mistake in last fore push(forgot add vendor-related changes).

This should be fine.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -29,7 +29,6 @@ require (
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822
github.com/pborman/uuid v1.2.0
github.com/pquerna/cachecontrol v0.0.0-20171018203845-0dec1b30a021 // indirect
github.com/prometheus/client_golang v0.9.4

This comment has been minimized.

Copy link
@RainbowMango

RainbowMango Oct 14, 2019

Author Member

FYI:
Removed this line making robot happy.

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Oct 14, 2019

/lgtm

@RainbowMango

This comment has been minimized.

Copy link
Member Author

commented Oct 14, 2019

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit f7992c7 into kubernetes:master Oct 14, 2019
15 checks passed
15 checks passed
cla/linuxfoundation RainbowMango authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 14, 2019
@RainbowMango RainbowMango deleted the RainbowMango:pr_remove_prometheus_reference_from_storage branch Oct 15, 2019
ohsewon added a commit to ohsewon/kubernetes that referenced this pull request Oct 16, 2019
…theus_reference_from_storage

Remove prometheus reference from storage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.