Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address `staticcheck` failures for `test/e2e/node/...` #83681

Conversation

@mattjmcnaughton
Copy link
Contributor

commented Oct 9, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Fix the staticcheck failures for test/e2e/node. All of the
staticcheck errors were for variables which were never used. When these
values were err, we added processing for the errors. When they were
values that were just never used, we stopped giving them a name.

Ref #81657

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
Fix the `staticcheck` failures for `test/e2e/node`. All of the
staticcheck errors were for variables which were never used. When these
values were `err`, we added processing for the errors. When they were
values that were just never used, we stopped giving them a name.
@mattjmcnaughton

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

/assign @vishh
/assign @liggitt

@liggitt

This comment has been minimized.

Copy link
Member

commented Oct 9, 2019

/priority backlog
/lgtm
/approve
/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mattjmcnaughton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4d6deea into kubernetes:master Oct 9, 2019
16 checks passed
16 checks passed
cla/linuxfoundation mattjmcnaughton authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 9, 2019
@mattjmcnaughton mattjmcnaughton deleted the mattjmcnaughton:mattjmcnaughton/fix-staticcheck-test-e2e-node branch Oct 10, 2019
@Random-Liu

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

This breaks the PreStop graceful pod terminated should wait until preStop hook completes the process.

I don't think it is introduced by this PR. It's just the newly added error check exposed the long standing issue.

I see the same error for both Docker and containerd:

@mattjmcnaughton

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2019

Thanks for catching this @Random-Liu !

What's the best path forward here?

Also, for my context, I'm not sure I've come across these tests before... confirming that they don't run as part of the main CI on prs?

@liggitt

This comment has been minimized.

Copy link
Member

commented Oct 11, 2019

I don't think it is introduced by this PR. It's just the newly added error check exposed the long standing issue.

is this a flake or a hard failure?

@liggitt

This comment has been minimized.

Copy link
Member

commented Oct 11, 2019

appears to be a flake (the test passes sometimes in kind and gce e2es)

marked as flaky in #83792. @Random-Liu, can you open a follow-up issue to track resolving the flake?

ohsewon added a commit to ohsewon/kubernetes that referenced this pull request Oct 16, 2019
…ton/fix-staticcheck-test-e2e-node

Address `staticcheck` failures for `test/e2e/node/...`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.