Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate TaintManager to use watch for listing pods instead of expensi… #83684

Conversation

@krzysied
Copy link
Contributor

commented Oct 9, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Cherry pick of #79370 on release-1.15.

#79370: Migrate TaintManager to use watch for pods instead of list call.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


…ve listing pods call.
@krzysied

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

Comparison of original kubernetes release 1.15 vs release 1.15 + taint manager fix.
Both versions were tested using density performance test.

List calls (green line is client=node-controller):

  • branch release-1.15 (eae0bfe)
    image
  • branch release-1.15 + cherry-pick (#79370)
    image

Call latency:

  • branch release-1.15 (eae0bfe)
    image
  • branch release-1.15 + cherry-pick (#79370)
    image

Allocation rate:

  • branch release-1.15 (eae0bfe)
    image
  • branch release-1.15 + cherry-pick (#79370)
    image
@krzysied

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

@k8s-ci-robot k8s-ci-robot requested review from mm4tt and wojtek-t Oct 9, 2019
@mm4tt

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

/lgtm
This is similar to #83666, see #83666 (comment) for justification why we should cherry-pick this.

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzysied, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tpepper

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

/retest

1 similar comment
@tpepper

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

/retest

@fejta-bot

This comment has been minimized.

Copy link

commented Oct 10, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit c2eb0ec into kubernetes:release-1.15 Oct 11, 2019
12 checks passed
12 checks passed
cla/linuxfoundation mborsz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@krzysied krzysied deleted the krzysied:automated-cherry-pick-of-#79370-upstream-release-1.15 branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.