Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce sig-instrumentation aliases in OWNERS_ALISES and simplify OWNERS files #83718

Merged
merged 1 commit into from Oct 10, 2019

Conversation

@serathius
Copy link
Contributor

serathius commented Oct 10, 2019

/kind cleanup
This PR introduces aliases groups and applies them in OWNERS files. As results sig-instrumentation directories have:

  • sig-instrumentation label
  • both sig leads as approves
  • one common set of reviewers for sig-instrumentation to allow faster review

For now only SIG leads were moved to sig-instrumentation-approvers, we can expand list in next PRs.
OWNERS files were found by greping for any sig leads github handle.

Algorithm for each OWNERS file
For approves: replace sig lead with sig-instrumentation-approvers, leave others untouched.
For reviewers: replace all entries with sig-instrumentation-reviewers and add replaced entries to sig-instrumentation-reviewers alias.

NONE

/cc @piosz @brancz

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Oct 10, 2019
@serathius serathius force-pushed the serathius:aliases branch from 0f1d094 to 58bee46 Oct 10, 2019
@serathius

This comment has been minimized.

Copy link
Contributor Author

serathius commented Oct 10, 2019

/retest

@RainbowMango

This comment has been minimized.

Copy link
Member

RainbowMango commented Oct 10, 2019

The robot is crazy today. :)
/joke

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 10, 2019

@RainbowMango: Some people say that comedians who tell one too many light bulb jokes soon burn out, but they don't know watt they are talking about. They're not that bright.

In response to this:

The robot is crazy today. :)
/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brancz

This comment has been minimized.

Copy link
Member

brancz commented Oct 10, 2019

/lgtm

Thanks for taking care of this!

@brancz

This comment has been minimized.

Copy link
Member

brancz commented Oct 10, 2019

/approve

@serathius

This comment has been minimized.

Copy link
Contributor Author

serathius commented Oct 10, 2019

/assign @wojtek-t

@serathius serathius force-pushed the serathius:aliases branch from 58bee46 to c601d34 Oct 10, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 10, 2019
@brancz

This comment has been minimized.

Copy link
Member

brancz commented Oct 10, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 10, 2019
@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Oct 10, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, serathius, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed request for brancz and piosz Oct 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 46dd075 into kubernetes:master Oct 10, 2019
16 checks passed
16 checks passed
cla/linuxfoundation serathius authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 10, 2019
ohsewon added a commit to ohsewon/kubernetes that referenced this pull request Oct 16, 2019
Introduce sig-instrumentation aliases in OWNERS_ALISES and simplify OWNERS files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.