Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off kubelet deprecated metrics #83841

Conversation

@RainbowMango
Copy link
Member

RainbowMango commented Oct 12, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Turn off metrics that have been deprecated in v1.14.

Refer to kubernetes/enhancements#1206:

Kubernetes 1.17 will remove the in 1.14 marked as deprecated metrics. As a stretch goal, if the metrics stability framework is in place, then in Kubernetes 1.17 the metrics will only be turned off by default through the stability framework. Should this not be available, then the metrics will be removed.

Which issue(s) this PR fixes:
Part of kubernetes/enhancements#1206

Special notes for your reviewer:
Wrong metrics names(prefix kubelet_ missed) in 1.14 release notes

  • docker_operations -> docker_operations_total.
  • docker_operations_latency_microseconds -> docker_operations_latency_seconds
  • docker_operations_errors -> docker_operations_errors_total
  • docker_operations_timeout -> docker_operations_timeout_total

If you want to do something about this, please let me know.

Does this PR introduce a user-facing change?:

Following metrics have been turned off:
- kubelet_pod_worker_latency_microseconds
- kubelet_pod_start_latency_microseconds
- kubelet_cgroup_manager_latency_microseconds
- kubelet_pod_worker_start_latency_microseconds
- kubelet_pleg_relist_latency_microseconds
- kubelet_pleg_relist_interval_microseconds
- kubelet_eviction_stats_age_microseconds
- kubelet_runtime_operations
- kubelet_runtime_operations_latency_microseconds
- kubelet_runtime_operations_errors
- kubelet_device_plugin_registration_count
- kubelet_device_plugin_alloc_latency_microseconds
- kubelet_docker_operations
- kubelet_docker_operations_latency_microseconds
- kubelet_docker_operations_errors
- kubelet_docker_operations_timeout
- network_plugin_operations_latency_microseconds

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/da4b7050ccae7a947e4d60f94ab28513e513a458/keps/sig-instrumentation/20181106-kubernetes-metrics-overhaul.md
@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Oct 13, 2019

/retest

@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Oct 14, 2019

Sorry to bother you. Maybe this triggered a potential bug, I need to investigate more.
/hold

@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Oct 30, 2019

Rely on #84135. Let's continue after that.

@RainbowMango RainbowMango force-pushed the RainbowMango:pr_hide_kubelet_deprecated_metrics branch from 54a796b to e92d420 Nov 11, 2019
@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Nov 12, 2019

/hold cancel
/cc @logicalhan @brancz @dashpole
/assign @vishh

/priority important-soon

Name: DeprecatedDockerOperationsLatencyKey,
Help: "Latency in microseconds of Docker operations. Broken down by operation type.",
StabilityLevel: metrics.ALPHA,
DeprecatedVersion: "1.16.0",

This comment has been minimized.

Copy link
@brancz

brancz Nov 12, 2019

Member

All of these were deprecated in 1.14.

pkg/kubelet/dockershim/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/kubelet/dockershim/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/kubelet/dockershim/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/kubelet/dockershim/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/kubelet/dockershim/network/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/kubelet/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/kubelet/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/kubelet/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/kubelet/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/kubelet/metrics/metrics.go Outdated Show resolved Hide resolved
@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Nov 14, 2019

/test pull-kubernetes-typecheck

@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Nov 14, 2019

/assign @derekwaynecarr
I hope we can put it to v1.17.

/milestone v1.17

@josiahbjorgaard

This comment has been minimized.

Copy link
Contributor

josiahbjorgaard commented Nov 15, 2019

/milestone v1.18

(code freeze v1.17)

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.17, v1.18 Nov 15, 2019
Copy link
Contributor

logicalhan left a comment

/lgtm

@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Nov 22, 2019

/assign @dashpole @derekwaynecarr

We are trying to cherry-pick it to v1.17. kubernetes/enhancements#1206 (comment)
/milestone v1.17

@dashpole

This comment has been minimized.

Copy link
Contributor

dashpole commented Nov 23, 2019

/approve

@josiahbjorgaard

This comment has been minimized.

Copy link
Contributor

josiahbjorgaard commented Dec 2, 2019

/assign @derekwaynecarr

@josiahbjorgaard

This comment has been minimized.

Copy link
Contributor

josiahbjorgaard commented Dec 2, 2019

@RainbowMango Can you follow up on having this PR approved for 1.17, since we are nearing the end of the release cycle?

@mrbobbytables

This comment has been minimized.

Copy link
Member

mrbobbytables commented Dec 2, 2019

From a conversation in Slack, I believe this is being punted to 1.18 --
https://kubernetes.slack.com/archives/CJH2GBF7Y/p1574882443299300

@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Dec 3, 2019

Kindly ping @kubernetes/sig-node-pr-reviews for approval.

@josiahbjorgaard
Yes, as mentioned by @mrbobbytables. Let's move it to 1.18.

/milestone v1.18

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.17, v1.18 Dec 3, 2019
@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Dec 6, 2019

@liggitt Can you help? Needs approval here.
This has been approved by @brancz and @dashpole, but also needs an approval label.

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 9, 2019

I'll defer to kubelet approvers

@yujuhong

This comment has been minimized.

Copy link
Member

yujuhong commented Dec 9, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, dashpole, RainbowMango, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ff8cf50 into kubernetes:master Dec 9, 2019
14 of 15 checks passed
14 of 15 checks passed
tide Not mergeable. Retesting: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation RainbowMango authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@RainbowMango RainbowMango deleted the RainbowMango:pr_hide_kubelet_deprecated_metrics branch Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.