Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual cherry pick of #83801: Upgrade to etcd 3.3.17 client + bbolt v1.3.3 #83968

Merged
merged 1 commit into from Oct 28, 2019

Conversation

@jpbetz
Copy link
Contributor

jpbetz commented Oct 15, 2019

Replaces #83915.

Upgrade to etcd 3.3.17 client. This is conceptually a cherrypick of #83801, but was done by running these commands directly on the release-1.16 branch:

hack/pin-dependency.sh github.com/coreos/etcd v3.3.17
hack/pin-dependency.sh github.com/coreos/bbolt v1.3.3
hack/update-vendor.sh

Fixes for two major issues with the etcd 3.3 client to 1.16:

  • etcd client does not parse IPv6 addresses correctly when members are joining
  • failover on multi-member etcd cluster fails certificate check on DNS mismatch

/kind bug
/priority critical-urgent
/cc @liggitt @wojtek-t @odinuge

Upgrade to etcd client 3.3.17 to fix bug where etcd client does not parse IPv6 addresses correctly when members are joining, and to fix bug where failover on multi-member etcd cluster fails certificate check on DNS mismatch
@jpbetz

This comment has been minimized.

Copy link
Contributor Author

jpbetz commented Oct 15, 2019

/retest

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Oct 15, 2019

looks good, but I had one question about bbolt in the master PR at #83801 (comment)

would like that resolved and the bbolt version in master made coherent before this merges

@jpbetz

This comment has been minimized.

Copy link
Contributor Author

jpbetz commented Oct 15, 2019

/hold

Let's target 1.16.3. We will wait until changes on master (both the etcd v3.3.17 and bbolt 1.3.3) have had time to soak and scale test before canceling the hold.

@jpbetz

This comment has been minimized.

Copy link
Contributor Author

jpbetz commented Oct 15, 2019

looks good, but I had one question about bbolt in the master PR at #83801 (comment)

would like that resolved and the bbolt version in master made coherent before this merges

Thanks. I'll get bbolt merged to master before releasing the hold on this PR. (I'll also update the hold comment so we don't forget)

Copy link
Member

odinuge left a comment

Both etcd #83801 and bbolt is now merged into master #83970. Thanks!

/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 17, 2019
@odinuge

This comment has been minimized.

Copy link
Member

odinuge commented Oct 17, 2019

/hold cancel

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Oct 17, 2019

Once we get successful scale test runs on master with the updated bbolt, this lgtm

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Oct 18, 2019

Today`s run has finished and it looks fine. So I think we can unblock this. @liggitt ?

[BTW, bbolt is not used in etcd client, right? So that dependency shouldn't even matter from our perspective, as long as we don't built etcd. What am I missing?]

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Oct 18, 2019

You're right.

/hold cancel

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Oct 18, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f2b2d8b into kubernetes:release-1.16 Oct 28, 2019
12 of 13 checks passed
12 of 13 checks passed
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation jpbetz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.