Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update etcd client to v3.4.3 in k8s v1.17 #83987

Merged
merged 4 commits into from Oct 25, 2019

Conversation

@wenjiaswe
Copy link
Contributor

wenjiaswe commented Oct 16, 2019

Replace #83209

What type of PR is this?
/kind feature

What this PR does / why we need it:
Update etcd client to v3.4.3 in k8s 1.17

Which issue(s) this PR fixes:

Fixes ##82641

Does this PR introduce a user-facing change?:

Update etcd client side to v3.4.3
Deprecated prometheus request meta-metrics have been removed (http_request_duration_microseconds, http_request_duration_microseconds_sum, http_request_duration_microseconds_count, http_request_size_bytes, http_request_size_bytes_sum, http_request_size_bytes_count, http_requests_total, http_response_size_bytes, http_response_size_bytes_sum, http_response_size_bytes_count) due to removal from the prometheus client library. Prometheus http request meta-metrics are now generated from [promhttp.InstrumentMetricHandler](https://godoc.org/github.com/prometheus/client_golang/prometheus/promhttp#InstrumentMetricHandler) instead.

/cc @wojtek-t @liggitt @jpbetz

@wenjiaswe

This comment has been minimized.

Copy link
Contributor Author

wenjiaswe commented Oct 16, 2019

/retest

1 similar comment
@wenjiaswe

This comment has been minimized.

Copy link
Contributor Author

wenjiaswe commented Oct 16, 2019

/retest

@wenjiaswe wenjiaswe force-pushed the wenjiaswe:etcd_client_3_4_2 branch from b9e9222 to 454a339 Oct 24, 2019
@wenjiaswe

This comment has been minimized.

Copy link
Contributor Author

wenjiaswe commented Oct 24, 2019

/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 24, 2019

@wenjiaswe: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-alpha-features b9e9222 link /test pull-kubernetes-e2e-gce-alpha-features
pull-kubernetes-e2e-gce-csi-serial b9e9222 link /test pull-kubernetes-e2e-gce-csi-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

logicalhan left a comment

/lgtm from an instrumentation POV

@wenjiaswe

This comment has been minimized.

Copy link
Contributor Author

wenjiaswe commented Oct 24, 2019

@liggitt All tests passed and @logicalhan lgtmed, PTAL. thanks.

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Oct 25, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 25, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, wenjiaswe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Oct 25, 2019

@wenjiaswe - I think we can hold cancel now, right? Or maybe we want to wait until Monday to not merge it on Friday?

@wenjiaswe

This comment has been minimized.

Copy link
Contributor Author

wenjiaswe commented Oct 25, 2019

@wojtek-t I only kept the hold because I thought we need to wait for #83968 to merge? Or is that not necessary?

@brancz

This comment has been minimized.

Copy link
Member

brancz commented Oct 25, 2019

Double checking things from instrumentation side as well and this lgtm as well.

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Oct 25, 2019

we don't need to wait for the 1.16 pick. we got scale results on master already.

/hold cancel

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Oct 25, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot k8s-ci-robot merged commit 09f453f into kubernetes:master Oct 25, 2019
17 checks passed
17 checks passed
cla/linuxfoundation logicalhan authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.