Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce node update frequency #84007

Merged

Conversation

@wojtek-t
Copy link
Member

wojtek-t commented Oct 16, 2019

Ref kubernetes/enhancements#589

Reduce default NodeStatusReportFrequency to 5 minutes. With this change, periodic node status updates will be send every 5m if node status doesn't change (otherwise they are still send with 10s).

Bump NodeProblemDetector version to v0.8.0 to reduce forced NodeStatus updates frequency to 5 minutes.
@smourapina

This comment has been minimized.

Copy link
Member

smourapina commented Oct 24, 2019

@wojtek-t @gmarek @Random-Liu Bug triage for 1.17 here with a gentle reminder that code freeze for this release is on November 14. Is this PR still intended for 1.17?

@wojtek-t

This comment has been minimized.

Copy link
Member Author

wojtek-t commented Oct 24, 2019

Yes - it is. And it will be merged by then.

@wojtek-t wojtek-t force-pushed the wojtek-t:reduce_node_update_frequency branch 2 times, most recently from b17c191 to a8498cc Oct 31, 2019
DEFAULT_NPD_VERSION="v0.7.1"
DEFAULT_NPD_SHA1="a9cae965973d586bf5206ad4fe5aae07e6bfd154"
DEFAULT_NPD_VERSION="v0.8.0"
DEFAULT_NPD_SHA1="276335fa25a703615cc2f2cdc51ba693fac4bdd70baa63f9cbf228291defd776"

This comment has been minimized.

Copy link
@wojtek-t

wojtek-t Oct 31, 2019

Author Member

@Random-Liu - it seems the sha is incorrect. Where I can get sha1 from?

This comment has been minimized.

Copy link
@wojtek-t

wojtek-t Nov 3, 2019

Author Member

never mind

@wojtek-t wojtek-t force-pushed the wojtek-t:reduce_node_update_frequency branch from a8498cc to 12c8b4a Nov 3, 2019
@wojtek-t

This comment has been minimized.

Copy link
Member Author

wojtek-t commented Nov 3, 2019

/retest

@wojtek-t wojtek-t changed the title [WIP] Reduce node update frequency Reduce node update frequency Nov 3, 2019
@wojtek-t wojtek-t assigned Random-Liu and derekwaynecarr and unassigned wojtek-t Nov 3, 2019
@wojtek-t

This comment has been minimized.

Copy link
Member Author

wojtek-t commented Nov 3, 2019

@derekwaynecarr

This comment has been minimized.

Copy link
Member

derekwaynecarr commented Nov 4, 2019

bumps time to previously discussed interval during kep discussion.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 4, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8ff16f3 into kubernetes:master Nov 4, 2019
16 checks passed
16 checks passed
cla/linuxfoundation wojtek-t authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@wojtek-t wojtek-t deleted the wojtek-t:reduce_node_update_frequency branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.