Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Adds x-kubernetes-map-type annotation as a CRD API extension #84113
What type of PR is this?
What this PR does / why we need it:
For more information on release notes see: https://git.k8s.io/community/contributors/guide/release-notes.md
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Hi @enxebre. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
I think we might need a follow up to this in kube-openapi, because it looks like the extension isn't wired all the way through: https://github.com/kubernetes/kube-openapi/blob/master/pkg/schemaconv/smd.go#L387-L388