Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add lenient decoding path for v1alpha1 kube-proxy config #84143
What type of PR is this?
What this PR does / why we need it:
This implements a lenient path for decoding a
The reason for this patch is that after discussion with sig-cluster-lifecycle we realized that
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
I've taken a stab at testing the lenient path for unknown/duplicate fields. Wasn't sure the best way to handle this since the behavior will change as we implement config API versions > v1alpha1 and the strict decoding behavior is expected.
Was thinking of maybe adding in a mechanism to specify the config API version per test, but wasn't sure the effort is warranted if things will just be removed once support for v1alpha1 is dropped.
I think it's worth it, whenever we have multiple concurrent versions, we should be testing that they all work.
Removed unneeded comments Matched style from other PR's Only print error when lenient decoding is successful Update Bazel for BUILD Comment out existing strict decoder tests Added tests for leniant path Added comments to explain test additions Cleanup TODO's and tests Add explicit newline for appended config
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing