Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated CSI RBAC roles #84282

Merged
merged 1 commit into from Oct 25, 2019

Conversation

@tedyu
Copy link
Contributor

tedyu commented Oct 24, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR removes deprecated built-in CSI RBAC roles, as #78739 mentioned.

Which issue(s) this PR fixes:
Fixes #78739

The built-in system:csi-external-provisioner and system:csi-external-attacher cluster roles are removed as of 1.17 release

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@yutedz yutedz force-pushed the yutedz:rm-csi-rbac-roles branch from 50d45df to 13596e5 Oct 24, 2019
@ncdc ncdc removed their request for review Oct 24, 2019
@tedyu

This comment has been minimized.

Copy link
Contributor Author

tedyu commented Oct 24, 2019

/test pull-kubernetes-e2e-gce

@tedyu

This comment has been minimized.

Copy link
Contributor Author

tedyu commented Oct 24, 2019

cc @verult

@tedyu

This comment has been minimized.

Copy link
Contributor Author

tedyu commented Oct 24, 2019

/priority important-soon

@verult

This comment has been minimized.

Copy link
Contributor

verult commented Oct 24, 2019

/sig storage
/cc @jsafrane @msau42

@k8s-ci-robot k8s-ci-robot requested review from jsafrane and msau42 Oct 24, 2019
@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Oct 25, 2019

/lgtm
/assign @liggitt

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Oct 25, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, tedyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a3560d3 into kubernetes:master Oct 25, 2019
15 checks passed
15 checks passed
cla/linuxfoundation yutedz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.