Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --runtime-config=api/beta=false, --feature-gates=AllBeta=false #84304

Merged
merged 1 commit into from Nov 15, 2019

Conversation

@liggitt
Copy link
Member

liggitt commented Oct 24, 2019

Allow disabling all beta features and APIs

What type of PR is this?
/kind feature

What this PR does / why we need it:
Allows disabling all build-in beta REST APIs and feature-gates

xref https://github.com/kubernetes/enhancements/blob/master/keps/sig-architecture/20191023-conformance-without-beta.md

Does this PR introduce a user-facing change?:

`--runtime-config` now supports an `api/beta=false` value which disables all built-in REST API versions matching `v[0-9]+beta[0-9]+`.
`--feature-gates` now supports an `AllBeta=false` value which disables all beta feature gates.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/pull/1332

/sig api-machinery
cc @BenTheElder @deads2k

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from apelisse and dims Oct 24, 2019
@liggitt liggitt requested review from deads2k and BenTheElder and removed request for dims and apelisse Oct 24, 2019
@jpbetz

This comment has been minimized.

Copy link
Contributor

jpbetz commented Oct 24, 2019

Looks correct to me.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 24, 2019
@liggitt liggitt force-pushed the liggitt:all-beta branch from 4693ae8 to e1caf80 Oct 28, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 28, 2019
@liggitt liggitt force-pushed the liggitt:all-beta branch from e1caf80 to e2f6ebe Nov 14, 2019
@liggitt liggitt changed the title WIP - Add support for --runtime-config=api/beta=false, --feature-gates=AllBeta=false Add support for --runtime-config=api/beta=false, --feature-gates=AllBeta=false Nov 14, 2019
@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Nov 14, 2019

…eta=false

Allow disabling all beta features and APIs
@liggitt liggitt force-pushed the liggitt:all-beta branch from e2f6ebe to a5760de Nov 14, 2019
@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Nov 14, 2019

/hold cancel
/priority important-longterm

@dims

This comment has been minimized.

Copy link
Member

dims commented Nov 14, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit f1e912c into kubernetes:master Nov 15, 2019
16 checks passed
16 checks passed
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 15, 2019
@liggitt liggitt deleted the liggitt:all-beta branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.