Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default etcd server to 3.4.3 #84329

Merged
merged 2 commits into from Oct 30, 2019

Conversation

@jingyih
Copy link
Contributor

jingyih commented Oct 25, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
We are updating etcd client version to 3.4.3 in #83987. This PR updates the default etcd server version to 3.4.3.

Does this PR introduce a user-facing change?:

Update default etcd server version to 3.4.3

/sig api-machinery
/area etcd
/priority important-soon

Fixes: #82641

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 25, 2019

Hi @jingyih. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jingyih

This comment has been minimized.

Copy link
Contributor Author

jingyih commented Oct 25, 2019

/hold
Until 3.4.3 image is pushed.
Until #83987 is merged.

@@ -425,8 +425,8 @@ var (
14: "3.3.10",
15: "3.3.10",
16: "3.3.15-0",
17: "3.3.17-0",

This comment has been minimized.

Copy link
@wenjiaswe

wenjiaswe Oct 25, 2019

Contributor

Do we want to change default of 16 to 3.3.17-0?

This comment has been minimized.

Copy link
@jingyih

jingyih Oct 25, 2019

Author Contributor

Make sense. ref: #83968

This comment has been minimized.

Copy link
@jpbetz

jpbetz Oct 25, 2019

Contributor

Yes, I'm in favor of updating to same patch version for all k8s versions using 3.3 in kubeadm.

@jingyih jingyih force-pushed the jingyih:update_etcd_server_to_3.4 branch 2 times, most recently from bfff515 to bbddd75 Oct 25, 2019
@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Oct 26, 2019

what's the process to get the images pushed?

@jingyih

This comment has been minimized.

Copy link
Contributor Author

jingyih commented Oct 28, 2019

what's the process to get the images pushed?

My current understanding of the process:

  1. build and push etcd-related images to gcr.io/k8s-image-staging

  2. test the new images in K8s cluster

  3. promote images from staging repo to gcr.io/google-containers via registry promoter.

@jpbetz

This comment has been minimized.

Copy link
Contributor

jpbetz commented Oct 28, 2019

cc @listx for ongoing gcr.io/google-containers promotion improvement efforts

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Oct 28, 2019

/approve
for kubeadm. thanks!

@jingyih

This comment has been minimized.

Copy link
Contributor Author

jingyih commented Oct 29, 2019

The 3.4.3 version of etcd and etcd-empty-dir-cleanup images are available in gcr.io/google-containers.
Can we get an "ok-to-test"?

@wenjiaswe

This comment has been minimized.

Copy link
Contributor

wenjiaswe commented Oct 29, 2019

/ok-to-test

@jingyih jingyih force-pushed the jingyih:update_etcd_server_to_3.4 branch from bbddd75 to 706cde5 Oct 29, 2019
@jingyih

This comment has been minimized.

Copy link
Contributor Author

jingyih commented Oct 29, 2019

/retest

@jingyih

This comment has been minimized.

Copy link
Contributor Author

jingyih commented Oct 29, 2019

/test pull-kubernetes-e2e-gce

@jingyih jingyih changed the title [WIP] Update default etcd server to 3.4.3 Update default etcd server to 3.4.3 Oct 29, 2019
@jingyih

This comment has been minimized.

Copy link
Contributor Author

jingyih commented Oct 29, 2019

All tests passed. PTAL.

/hold cancel

@jingyih

This comment has been minimized.

Copy link
Contributor Author

jingyih commented Oct 29, 2019

@k8s-ci-robot k8s-ci-robot requested review from dims, liggitt and wojtek-t Oct 29, 2019
@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Oct 29, 2019

/test pull-kubernetes-e2e-kind
should end in about 20 minutes (creates a kubeadm / kind cluster using the new etcd).

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Oct 30, 2019

/lgtm
/approve

Let's merge this asap to have as much soaking time as possible before the release.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingyih, neolit123, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e1d3cc7 into kubernetes:master Oct 30, 2019
17 checks passed
17 checks passed
cla/linuxfoundation jingyih authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.