Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Alpha feature MountContainers #84365

Merged
merged 1 commit into from Nov 4, 2019

Conversation

@codenrhoden
Copy link
Member

codenrhoden commented Oct 25, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
The alpha feature for mount containers is unused, and is
superseded by CSI. By removing it, we can remove a lot of unnecessary
code, and also clean up the mount library even more before moving it out
of tree.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
The deprecation policy for an alpha feature states that it can be removed without going through a deprecation period.

Does this PR introduce a user-facing change?:

Removed Alpha feature `MountContainers`

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


The alpha feature for mount containers is unused, and is
superseded by CSI. By removing it, we can remove a lot of unnecessary
code, and also clean up the mount library even more before moving it out
of tree.
@codenrhoden

This comment has been minimized.

Copy link
Member Author

codenrhoden commented Oct 25, 2019

Copy link
Contributor

mattjmcnaughton left a comment

/assign @derekwaynecarr

/lgtm
LGTM from a sig-node perspective :) Always happy to see unused code being deleted! Will let someone from the storage sign off from a feature perspective.

@dims

This comment has been minimized.

Copy link
Member

dims commented Oct 28, 2019

/approve
/lgtm

Thanks @codenrhoden

@dims

This comment has been minimized.

Copy link
Member

dims commented Oct 28, 2019

/milestone v1.17

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 28, 2019
@jsafrane

This comment has been minimized.

Copy link
Member

jsafrane commented Oct 31, 2019

/approve
from sig-storage perspective

Copy link
Member

saad-ali left a comment

/lgtm
/approve

@saad-ali

This comment has been minimized.

Copy link
Member

saad-ali commented Oct 31, 2019

/assign @derekwaynecarr

@derekwaynecarr

This comment has been minimized.

Copy link
Member

derekwaynecarr commented Nov 4, 2019

kubelet changes look good.

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codenrhoden, derekwaynecarr, dims, jsafrane, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 08410cb into kubernetes:master Nov 4, 2019
18 checks passed
18 checks passed
cla/linuxfoundation codenrhoden authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@codenrhoden codenrhoden deleted the codenrhoden:rm-mount-container branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.