Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm-validators: bump the latest validated Docker version to 19.03 #84476

Merged
merged 1 commit into from Oct 29, 2019

Conversation

@neolit123
Copy link
Member

neolit123 commented Oct 28, 2019

What this PR does / why we need it:

19.03 has been validated for a while, see:
#82326 (comment)

also kubekins @ test-infra is already at 19*.

Which issue(s) this PR fixes:

Fixes #82326
Fixes kubernetes/kubeadm#1821

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update the latest validated version of Docker to 19.03

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/assign @BenTheElder @yastij @timothysc
/kind feature
/priority important-longterm

@neolit123

This comment has been minimized.

Copy link
Member Author

neolit123 commented Oct 28, 2019

@yastij if we move the validators to the new repository how would the ./hack/verify script work?
does it have to be extended to also support downloading files from another repo and check them?

@neolit123

This comment has been minimized.

Copy link
Member Author

neolit123 commented Oct 28, 2019

/retest

@yastij

This comment has been minimized.

Copy link
Member

yastij commented Oct 28, 2019

If we want to keep them in sync yes. we’d need to discuss this with sig-release, as we’ll need to pin repo at specific git ref on dependencies.yaml

Copy link
Member

yastij left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 28, 2019
@yastij

This comment has been minimized.

Copy link
Member

yastij commented Oct 28, 2019

/retest

@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Oct 28, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added a commit that referenced this pull request Oct 29, 2019
kubeadm-validators: bump the latest validated Docker version to 19.03
@k8s-ci-robot k8s-ci-robot merged commit 28887de into kubernetes:master Oct 29, 2019
16 checks passed
16 checks passed
cla/linuxfoundation neolit123 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot merged commit 772e2e4 into kubernetes:master Oct 29, 2019
16 checks passed
16 checks passed
cla/linuxfoundation neolit123 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.